refactooring of checkrange's unit tests #4772
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 01e6d44.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 01e6d44.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkrange unit tests existed as 3 (for ydb based disks, nrd, mirror) almost identical test suits. Now it was moved into the one codebase as a part of volume_ut tests with disk's type as a parameter for test case.
Comparing to previous code, tests have only minor changes. Logically it is almost the same.
"Almost" - for example, we had test with logical error. "ShouldGetSameChecksumsWhileCheckRangeSimmilarDisks" was designed to check writing to 2 disks, but it was done into one disks with 2 clients. This testcase was replaced by different, but logically similar "DoTestShouldGetSameChecksumsWhileCheckRangeEqualBlocks" test.
// This refactoring has done as a part of checkrange utility improvements.