fix: if database pass name to query params and to backend handlers #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested changes
Feb 24, 2025
Raubzeug
force-pushed
the
preserve-database-param
branch
from
f5adb59 to
ac89a5a
Compare
artemmufazalov
requested changes
Feb 26, 2025
Comment on lines
+70
to
+75
| const locationSearch = new URLSearchParams(window.location.search); | ||
| const database = locationSearch.get('database'); | ||
| if (database) { | ||
| extendedQuery = {...extendedQuery, database}; | ||
| } | ||
|
|
There was a problem hiding this comment.
You should only add database if there is no database in initial query. So it should be like
extendedQuery = {database, ...extendedQuery}| @@ -163,6 +163,7 @@ function Diagnostics(props: DiagnosticsProps) { | |||
| wrapTo={({id}, node) => { | |||
| const path = getTenantPath({ | |||
| ...queryParams, | |||
| database: tenantName, | |||
There was a problem hiding this comment.
You already have database in queryParams, ...queryParams is enough
| @@ -48,6 +49,7 @@ export const TabletInfo = ({tablet}: TabletInfoProps) => { | |||
| tabletInfo.push({ | |||
| label: tabletInfoKeyset('field_hive'), | |||
| value: ( | |||
| //TODO: add database to getTabletPagePath after fix in backend | |||
There was a problem hiding this comment.
What fix on backend is needed?
Comment on lines
+131
to
+133
| tenantName, | ||
| location, | ||
| tenantName, |
There was a problem hiding this comment.
tenantName is passed twice
Comment on lines
+190
to
+191
| // TODO: add database when backend support it | ||
| // database={database?.toString()} |
There was a problem hiding this comment.
What support from backend is needed?
| {concurrentId, signal}: AxiosOptions = {}, | ||
| ) { | ||
| return this.get<TPDiskInfoResponse>( | ||
| this.getPath('/pdisk/info'), | ||
| { | ||
| node_id: nodeId, | ||
| pdisk_id: pDiskId, | ||
| database, |
There was a problem hiding this comment.
PDisk doesn't relate to specific database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1970
stand
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 80.62 MB | Main: 80.61 MB
Diff: +0.01 MB (0.01%)
ℹ️ CI Information