feat(Header): add link to shared DB for serverless by Raubzeug · Pull Request #4254 · ydb-platform/ydb-embedded-ui

Raubzeug · 2026-08-20T09:27:58Z

Greptile Summary

This change adds a viewer-only header action that lets users navigate from a serverless database to its shared database.

The shared-database target is selected as a resource ID while cluster settings are unresolved. When use_meta_proxy later resolves to false, the target switches to the shared database name. The action can therefore expose an ID-based route during loading for clusters that ultimately require name-based routing.

T-Rex validation blocked

The focused UI test exercised the loading and resolved-settings states, but a live YDB viewer backend service was unavailable to open the transient resource-ID route and observe its backend response.

Confidence Score: 4/5

The header action should wait for the proxy configuration before choosing a route representation, so viewers are not directed to an unsupported shared-database URL.

A focused rendered-component test confirmed that unresolved settings produce a resource-ID URL and that resolving use_meta_proxy to false changes the route to the shared database name. The backend response for the transient route could not be observed without a live viewer service.

Files Needing Attention: src/containers/Header/HeaderActionsMenu.tsx

T-Rex Logs

What T-Rex did

T-Rex attempted a focused rendered-component test with settings undefined, then settings.use_meta_proxy = false, using different resource-ID and shared-name values; the test observed the initial ID route /database?clusterName=main&database=shared-resource-id and the resolved name route /database?clusterName=main&database=%2FRoot%2Fshared, but a live YDB viewer backend was unavailable, so opening the transient ID route and observing the claimed backend resolution failure could not be completed.
The test outcome was blocked / inconclusive on the claimed backend usability, while the premature ID-link state was supported by the executed focused UI test, and the test logged the initial ID href, the transient hidden state after use_meta_proxy:false, and the final shared-name href, with a recommended next action to run the same browser flow against a viewer fixture or live viewer backend and capture the actual request/response, deferring if useClusterProxySettingResolved() is not true.

_{Ran code and verified through T-Rex}

Prompt To Fix All With AI

### Issue 1
src/containers/Header/HeaderActionsMenu.tsx:48
**Unresolved proxy mode selects IDs**

When `uiFactory.useDatabaseId` is enabled and cluster settings are still loading before resolving `use_meta_proxy` to false, this expression selects `ResourceId` mode prematurely, causing the menu to expose a database-ID URL that the active viewer backend does not resolve.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

_{Reviews (1): Last reviewed commit: "feat(Header): add link to shared DB for ..." | Re-trigger Greptile}

Greptile also left 1 inline comment on this PR.

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total	Passed	Failed	Flaky	Skipped
950	949	0	1	0

Test Changes Summary ✨3

✨ New Tests (3)

resolves the shared database with describe for a monitoring user (tenant/headerActions.test.ts)
uses a storage-free tenant lookup for a viewer-only user (tenant/headerActions.test.ts)
falls back to a storage-free tenant lookup when describe fails (tenant/headerActions.test.ts)

Bundle Size: 🔺

Current: 65.58 MB | Main: 65.56 MB
Diff: +0.02 MB (0.03%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information

Test recordings for failed tests are available in the full report.
Bundle size is measured for the entire 'dist' directory.
📊 indicates links to detailed reports.
🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55a82fc3e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a122139dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c542f1878a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58f70b9fa1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

astandrik

Requesting changes for the storage-heavy shared-name lookup and the proxy-mode error path. Please restore focused hook coverage for loading/error, ID/name selection, and runtime identity while fixing them.

astandrik · 2026-08-27T08:48:01Z

+    const isMetaDatabasesAvailable = useDatabasesV2();
+    const {settings, isResolved: isClusterBaseInfoResolved} = useClusterBaseInfo();
+
+    const useDatabaseId = uiFactory.useDatabaseId && settings?.use_meta_proxy !== false;


Do not treat a failed settings request as a resolved proxy mode.

Repro:

Configure a package consumer with useDatabaseId: true while the cluster has use_meta_proxy: false.

Let the Serverless database request succeed, but make cluster-base-info fail.

Open the database menu.

The cluster hook counts isError as resolved. settings stays undefined, so this expression selects ID mode. The link then uses ResourceId, which direct Viewer cannot resolve.

Keep the action hidden on this error path, or expose enough query state to distinguish success/no-fetch from failure. Add a hook test for the error case.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 589b574026

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88a7ec0d60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-28T14:46:26Z

+        return (
+            sharedDatabaseNameFromViewer ??
+            databases?.find(({Id}) => Id === databaseData?.ResourceId)?.Name
+        );


Derive the backend from the shared database

When meta-proxy routing is disabled and “Use cluster balancer as backend” is off, prepareTenantBackend needs a node ID belonging to the destination database. The lookup finds the shared tenant but retains only its Name, and line 152 subsequently prepares the link from the serverless databaseData; database metadata fetched individually commonly has no shared node IDs, so this falls back to the current serverless backend and can route the shared-database URL through the wrong node. Preserve the matched shared tenant (or its NodeIds) and derive the target backend from it.

AGENTS.md reference: AGENTS.md:L89-L89

Useful? React with 👍 / 👎.

Raubzeug marked this pull request as ready for review August 20, 2026 09:28

Copilot AI lite review requested due to automatic review settings August 20, 2026 09:28

Raubzeug requested review from astandrik and kkdras as code owners August 20, 2026 09:28

Copilot AI reviewed Aug 20, 2026

greptile-apps Bot reviewed Aug 20, 2026

View reviewed changes

Comment thread src/containers/Header/HeaderActionsMenu.tsx Outdated

chatgpt-codex-connector Bot reviewed Aug 20, 2026

View reviewed changes

Comment thread src/containers/Header/hooks/useSharedDatabasePath.ts Outdated

chatgpt-codex-connector Bot reviewed Aug 21, 2026

View reviewed changes

Comment thread src/containers/Header/hooks/useSharedDatabasePath.ts Outdated

chatgpt-codex-connector Bot reviewed Aug 21, 2026

View reviewed changes

Comment thread src/containers/Header/hooks/useSharedDatabasePath.ts Outdated

chatgpt-codex-connector Bot reviewed Aug 21, 2026

View reviewed changes

Comment thread src/containers/Header/hooks/useSharedDatabasePath.ts Outdated

kkdras reviewed Aug 27, 2026

View reviewed changes

Comment thread src/containers/Header/hooks/useSharedDatabasePath.ts

astandrik requested changes Aug 27, 2026

View reviewed changes

Raubzeug added 8 commits August 28, 2026 14:46

feat(Header): add link to shared DB for serverless

146946c

fix

9a4a389

fix

5991e9b

fix

2b6708d

fix

0d4ea17

fix

1f2f1ee

fix

c985fc7

fix

589b574

Raubzeug force-pushed the show-shared branch from 659845f to 589b574 Compare August 28, 2026 13:58

chatgpt-codex-connector Bot reviewed Aug 28, 2026

View reviewed changes

Comment thread src/containers/Header/hooks/useSharedDatabasePath.ts

Raubzeug added 2 commits August 28, 2026 17:39

fix

de5941e

fix

88a7ec0

Raubzeug requested review from astandrik and kkdras August 28, 2026 14:43

Raubzeug assigned Raubzeug and unassigned Raubzeug Aug 28, 2026

Raubzeug added size/m feedback labels Aug 28, 2026

chatgpt-codex-connector Bot reviewed Aug 28, 2026

View reviewed changes

Uh oh!

Conversation

Raubzeug commented Aug 20, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

T-Rex validation blocked

Confidence Score: 4/5

T-Rex Logs

CI Results

Test Status: ⚠️ FLAKY

✨ New Tests (3)

Bundle Size: 🔺

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

astandrik left a comment

Choose a reason for hiding this comment

Uh oh!

astandrik Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

Raubzeug Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Raubzeug commented Aug 20, 2026 •

edited by github-actions Bot

Loading