enable goerr113 linter

.golangci.yml

@@ -231,7 +231,6 @@ linters:
     - gochecknoglobals
     - gocognit
     - godot
-    - goerr113
     - golint
     - ifshort
     - interfacebloat

balancers/config.go

@@ -2,7 +2,6 @@ package balancers
 
 import (
 	"encoding/json"
-	"fmt"
 
 	balancerConfig "github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer/config"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
@@ -61,7 +60,10 @@ func createByType(t balancerType) (*balancerConfig.Config, error) {
 	case typeRoundRobin:
 		return RoundRobin(), nil
 	default:
-		return nil, xerrors.WithStackTrace(fmt.Errorf("unknown type of balancer: %s", t))
+		return nil, xerrors.WithStackTrace(&balancerTypeError{
+			message: "unknown type of balancer: %s",
+			bType:   t,
+		})
 	}
 }
 
@@ -96,7 +98,10 @@ func CreateFromConfig(s string) (*balancerConfig.Config, error) {
 		return PreferLocalDC(b), nil
 	case preferTypeLocations:
 		if len(c.Locations) == 0 {
-			return nil, xerrors.WithStackTrace(fmt.Errorf("empty locations list in balancer '%s' config", c.Type))
+			return nil, xerrors.WithStackTrace(&balancerTypeError{
+				message: "empty locations list in balancer '%s' config",
+				bType:   c.Type,
+			})
 		}
 		if c.Fallback {
 			return PreferLocationsWithFallback(b, c.Locations...), nil

balancers/errors.go

@@ -0,0 +1,12 @@
+package balancers
+
+import "fmt"
+
+type balancerTypeError struct {
+	message string
+	bType   balancerType
+}
+
+func (e *balancerTypeError) Error() string {
+	return fmt.Sprintf(e.message, e.bType)
+}

examples/basic/native/query/main.go

@@ -9,7 +9,7 @@ import (
 	"time"
 
 	environ "github.com/ydb-platform/ydb-go-sdk-auth-environ"
-	ydb "github.com/ydb-platform/ydb-go-sdk/v3"
+	"github.com/ydb-platform/ydb-go-sdk/v3"
 	"github.com/ydb-platform/ydb-go-sdk/v3/sugar"
 )
 
@@ -19,6 +19,7 @@ func isYdbVersionHaveQueryService() error {
 	for i, component := range ydbVersion {
 		if i < len(minYdbVersion) {
 			if r := strings.Compare(component, minYdbVersion[i]); r < 0 {
+				//nolint:goerr113
 				return fmt.Errorf("example '%s' run on minimal YDB version '%v', but current version is '%s'",
 					os.Args[0],
 					strings.Join(minYdbVersion, "."),

examples/read_table/main.go

@@ -9,7 +9,7 @@ import (
 	"path"
 
 	environ "github.com/ydb-platform/ydb-go-sdk-auth-environ"
-	ydb "github.com/ydb-platform/ydb-go-sdk/v3"
+	"github.com/ydb-platform/ydb-go-sdk/v3"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table/options"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table/types"
 )

examples/serverless/url_shortener/service.go

@@ -22,7 +22,7 @@ import (
 	"github.com/prometheus/client_golang/prometheus/promhttp"
 	environ "github.com/ydb-platform/ydb-go-sdk-auth-environ"
 	ydbMetrics "github.com/ydb-platform/ydb-go-sdk-prometheus/v2"
-	ydb "github.com/ydb-platform/ydb-go-sdk/v3"
+	"github.com/ydb-platform/ydb-go-sdk/v3"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table/options"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table/result"
@@ -306,7 +306,7 @@ func (s *service) selectLong(ctx context.Context, hash string) (url string, err
 		}
 	}
 
-	return "", fmt.Errorf("hash '%s' is not found", hash)
+	return "", fmt.Errorf("hash '%s' is not found", hash) //nolint:goerr113
 }
 
 func writeResponse(w http.ResponseWriter, statusCode int, body string) {
@@ -390,7 +390,7 @@ func (s *service) handleShorten(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	if !isLongCorrect(string(url)) {
-		err = fmt.Errorf("'%s' is not a valid URL", url)
+		err = fmt.Errorf("'%s' is not a valid URL", url) //nolint:goerr113
 		writeResponse(w, http.StatusBadRequest, err.Error())
 
 		return
@@ -428,7 +428,7 @@ func (s *service) handleLonger(w http.ResponseWriter, r *http.Request) {
 	}()
 	path := strings.Split(r.URL.Path, "/")
 	if !isShortCorrect(path[len(path)-1]) {
-		err = fmt.Errorf("'%s' is not a valid short path", path[len(path)-1])
+		err = fmt.Errorf("'%s' is not a valid short path", path[len(path)-1]) //nolint:goerr113
 		writeResponse(w, http.StatusBadRequest, err.Error())
 
 		return

examples/topic/cdc-cache-bus-freeseats/webserver.go

@@ -15,7 +15,10 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/table/types"
 )
 
-var errNotEnthoughtFreeSeats = errors.New("not enough free seats")
+var (
+	errNotEnthoughtFreeSeats = errors.New("not enough free seats")
+	errNotFound              = errors.New("not found")
+)
 
 type server struct {
 	cache     *Cache
@@ -133,7 +136,7 @@ SELECT freeSeats FROM bus WHERE id=$id;
 	if !res.NextRow() {
 		freeSeats = 0
 
-		return 0, errors.New("not found")
+		return 0, errNotFound
 	}
 
 	err = res.ScanWithDefaults(&freeSeats)

examples/topic/cdc-fill-and-read/main.go

@@ -10,7 +10,7 @@ import (
 	"time"
 
 	environ "github.com/ydb-platform/ydb-go-sdk-auth-environ"
-	ydb "github.com/ydb-platform/ydb-go-sdk/v3"
+	"github.com/ydb-platform/ydb-go-sdk/v3"
 	"github.com/ydb-platform/ydb-go-sdk/v3/topic/topicoptions"
 	"github.com/ydb-platform/ydb-go-sdk/v3/topic/topictypes"
 )

examples/topic/cdc-fill-and-read/tables.go

@@ -8,7 +8,7 @@ import (
 	"strconv"
 	"time"
 
-	ydb "github.com/ydb-platform/ydb-go-sdk/v3"
+	"github.com/ydb-platform/ydb-go-sdk/v3"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table/options"
 	"github.com/ydb-platform/ydb-go-sdk/v3/table/types"

examples/topic/topicreader/topicreader_advanced.go

@@ -10,6 +10,8 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/topic/topicreader"
 )
 
+var errBadDataLen = errors.New("bad data len")
+
 // ReadMessagesWithCustomBatching example of custom of readed message batch
 func ReadMessagesWithCustomBatching(ctx context.Context, db *ydb.Driver) {
 	reader, _ := db.Topic().StartReader("consumer", nil)
@@ -31,7 +33,7 @@ type MyMessage struct {
 // UnmarshalYDBTopicMessage implements topicreader.MessageContentUnmarshaler interface
 func (m *MyMessage) UnmarshalYDBTopicMessage(data []byte) error {
 	if len(data) != 6 {
-		return errors.New("bad data len")
+		return errBadDataLen
 	}
 	m.ID = data[0]
 	m.ChangeType = data[1]

examples/ttl/main.go

@@ -8,7 +8,7 @@ import (
 	"path"
 
 	environ "github.com/ydb-platform/ydb-go-sdk-auth-environ"
-	ydb "github.com/ydb-platform/ydb-go-sdk/v3"
+	"github.com/ydb-platform/ydb-go-sdk/v3"
 	"github.com/ydb-platform/ydb-go-sdk/v3/sugar"
 )
 

examples/ttl_readtable/main.go

@@ -8,7 +8,7 @@ import (
 	"path"
 
 	environ "github.com/ydb-platform/ydb-go-sdk-auth-environ"
-	ydb "github.com/ydb-platform/ydb-go-sdk/v3"
+	"github.com/ydb-platform/ydb-go-sdk/v3"
 	"github.com/ydb-platform/ydb-go-sdk/v3/sugar"
 )
 

internal/background/worker.go

@@ -12,6 +12,7 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xsync"
 )
 
+//nolint:goerr113
 var (
 	ErrAlreadyClosed       = xerrors.Wrap(errors.New("ydb: background worker already closed"))
 	errClosedWithNilReason = xerrors.Wrap(errors.New("ydb: background worker closed with nil reason"))

internal/balancer/balancer.go

@@ -24,7 +24,7 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/trace"
 )
 
-var ErrNoEndpoints = xerrors.Wrap(fmt.Errorf("no endpoints"))
+var ErrNoEndpoints = xerrors.Wrap(fmt.Errorf("no endpoints")) //nolint:goerr113
 
 type discoveryClient interface {
 	closer.Closer

internal/balancer/local_dc.go

@@ -15,6 +15,11 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
 )
 
+var (
+	errEmptyEndpointsList      = errors.New("empty endpoints list")
+	errFailCheckFastestAddress = errors.New("failed to check fastest address")
+)
+
 const (
 	maxEndpointsCheckPerLocation = 5
 )
@@ -64,7 +69,7 @@ func checkFastestAddress(ctx context.Context, addresses []string) string {
 
 func detectFastestEndpoint(ctx context.Context, endpoints []endpoint.Endpoint) (endpoint.Endpoint, error) {
 	if len(endpoints) == 0 {
-		return nil, xerrors.WithStackTrace(errors.New("empty endpoints list"))
+		return nil, xerrors.WithStackTrace(errEmptyEndpointsList)
 	}
 
 	var lastErr error
@@ -86,7 +91,7 @@ func detectFastestEndpoint(ctx context.Context, endpoints []endpoint.Endpoint) (
 			continue
 		}
 		if len(addresses) == 0 {
-			lastErr = xerrors.WithStackTrace(fmt.Errorf("no ips for fqdn: %q", host))
+			lastErr = xerrors.WithStackTrace(fmt.Errorf("no ips for fqdn: %q", host)) //nolint:goerr113
 
 			continue
 		}
@@ -106,7 +111,7 @@ func detectFastestEndpoint(ctx context.Context, endpoints []endpoint.Endpoint) (
 
 	fastestAddress := checkFastestAddress(ctx, addressesToPing)
 	if fastestAddress == "" {
-		return nil, xerrors.WithStackTrace(errors.New("failed to check fastest address"))
+		return nil, xerrors.WithStackTrace(errFailCheckFastestAddress)
 	}
 
 	return addressToEndpoint[fastestAddress], nil

internal/cmd/gstack/utils/utils.go

@@ -1,6 +1,7 @@
 package utils
 
 import (
+	"errors"
 	"fmt"
 	"go/ast"
 	"go/parser"
@@ -13,6 +14,11 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/version"
 )
 
+var (
+	errGettingIdentFromExpr = errors.New("error during getting ident from expr")
+	errGetPackageName       = errors.New("error during get package name function")
+)
+
 type FunctionIDArg struct {
 	FuncDecl *ast.FuncDecl
 	ArgPos   token.Pos
@@ -32,8 +38,10 @@ func ReadFile(filename string, info fs.FileInfo) ([]byte, error) {
 		return nil, err
 	}
 	if n < size {
+		//nolint:goerr113
 		return nil, fmt.Errorf("error: size of %q changed during reading (from %d to %d bytes)", filename, size, n)
 	} else if n > size {
+		//nolint:goerr113
 		return nil, fmt.Errorf("error: size of %q changed during reading (from %d to >=%d bytes)", filename, size, len(src))
 	}
 
@@ -120,15 +128,15 @@ func getIdentNameFromExpr(expr ast.Expr) (string, error) {
 	case *ast.IndexListExpr:
 		return getIdentNameFromExpr(expr.X)
 	default:
-		return "", fmt.Errorf("error during getting ident from expr")
+		return "", errGettingIdentFromExpr
 	}
 }
 
 func getPackageName(fset *token.FileSet, arg FunctionIDArg) (string, error) {
 	file := fset.File(arg.ArgPos)
 	parsedFile, err := parser.ParseFile(fset, file.Name(), nil, parser.PackageClauseOnly)
 	if err != nil {
-		return "", fmt.Errorf("error during get package name function")
+		return "", errGetPackageName
 	}
 
 	return parsedFile.Name.Name, nil

internal/cmd/gtrace/main.go

@@ -3,6 +3,7 @@ package main
 import (
 	"bufio"
 	"bytes"
+	"errors"
 	"flag"
 	"fmt"
 	"go/ast"
@@ -20,6 +21,8 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
 )
 
+var errUnsupportedNumberOfFuncResults = errors.New("unsupported number of function results")
+
 //nolint:gocyclo
 func main() {
 	var (
@@ -276,9 +279,7 @@ func buildFunc(info *types.Info, traces map[string]*Trace, fn *ast.FuncType) (re
 		return ret, nil
 	}
 	if len(fn.Results.List) > 1 {
-		return nil, fmt.Errorf(
-			"unsupported number of function results",
-		)
+		return nil, errUnsupportedNumberOfFuncResults
 	}
 
 	r := fn.Results.List[0]
@@ -302,6 +303,7 @@ func buildFunc(info *types.Info, traces map[string]*Trace, fn *ast.FuncType) (re
 		}
 	}
 
+	//nolint:goerr113
 	return nil, fmt.Errorf(
 		"unsupported function result type %s",
 		info.TypeOf(r.Type),

internal/conn/conn.go

@@ -25,13 +25,13 @@ import (
 
 var (
 	// errOperationNotReady specified error when operation is not ready
-	errOperationNotReady = xerrors.Wrap(fmt.Errorf("operation is not ready yet"))
+	errOperationNotReady = xerrors.Wrap(fmt.Errorf("operation is not ready yet")) //nolint:goerr113
 
 	// errClosedConnection specified error when connection are closed early
-	errClosedConnection = xerrors.Wrap(fmt.Errorf("connection closed early"))
+	errClosedConnection = xerrors.Wrap(fmt.Errorf("connection closed early")) //nolint:goerr113
 
 	// errUnavailableConnection specified error when connection are closed early
-	errUnavailableConnection = xerrors.Wrap(fmt.Errorf("connection unavailable"))
+	errUnavailableConnection = xerrors.Wrap(fmt.Errorf("connection unavailable")) //nolint:goerr113
 )
 
 type Conn interface {

internal/conn/error_test.go

@@ -7,29 +7,30 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+var (
+	errTest  = errors.New("test")
+	errTest2 = errors.New("test2")
+)
+
 func TestNodeErrorError(t *testing.T) {
-	testErr := errors.New("test")
-	nodeErr := newConnError(1, "localhost:1234", testErr)
+	nodeErr := newConnError(1, "localhost:1234", errTest)
 	message := nodeErr.Error()
 
 	require.Equal(t, "connError{node_id:1,address:'localhost:1234'}: test", message)
 }
 
 func TestNodeErrorUnwrap(t *testing.T) {
-	testErr := errors.New("test")
-	nodeErr := newConnError(1, "asd", testErr)
+	nodeErr := newConnError(1, "asd", errTest)
 
 	unwrapped := errors.Unwrap(nodeErr)
-	require.Equal(t, testErr, unwrapped)
+	require.Equal(t, errTest, unwrapped)
 }
 
 func TestNodeErrorIs(t *testing.T) {
-	testErr := errors.New("test")
-	testErr2 := errors.New("test2")
-	nodeErr := newConnError(1, "localhost:1234", testErr)
+	nodeErr := newConnError(1, "localhost:1234", errTest)
 
-	require.ErrorIs(t, nodeErr, testErr)
-	require.NotErrorIs(t, nodeErr, testErr2)
+	require.ErrorIs(t, nodeErr, errTest)
+	require.NotErrorIs(t, nodeErr, errTest2)
 }
 
 type testType1Error struct {

internal/coordination/client.go

@@ -24,6 +24,7 @@ import (
 
 //go:generate mockgen -destination grpc_client_mock_test.go -package coordination -write_package_comment=false github.com/ydb-platform/ydb-go-genproto/Ydb_Coordination_V1 CoordinationServiceClient,CoordinationService_SessionClient
 
+//nolint:goerr113
 var errNilClient = xerrors.Wrap(errors.New("coordination client is not initialized"))
 
 type Client struct {