Skip to content

fix query examples: add declare & change scan type #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix query examples: add declare & change scan type #1712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 27 additions & 11 deletions query/example_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,16 @@
}
defer db.Close(ctx) // cleanup resources
var (
id int32 // required value
id uint64 // required value
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scan to types other than those stored in the database does not work

myStr string // required value
)
// Do retry operation on errors with best effort
row, err := db.Query().QueryRow(ctx, // context manage exiting from Do
`SELECT CAST($id AS Uint64) AS id, CAST($myStr AS Text) AS myStr`,
`
DECLARE $id AS Uint64;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1713

DECLARE $myStr AS Text;
SELECT CAST($id AS Uint64) AS id, CAST($myStr AS Text) AS myStr
`,
query.WithParameters(
ydb.ParamsBuilder().
Param("$id").Uint64(123).
Expand Down Expand Up @@ -243,13 +247,17 @@
}
defer db.Close(ctx) // cleanup resources
var (
id int32 // required value
id uint64 // required value
myStr string // required value
)
var stats query.Stats
// Do retry operation on errors with best effort
row, err := db.Query().QueryRow(ctx, // context manage exiting from Do
`SELECT CAST($id AS Uint64) AS id, CAST($myStr AS Text) AS myStr`,
`
DECLARE $id AS Uint64;
DECLARE $myStr AS Text;
SELECT CAST($id AS Uint64) AS id, CAST($myStr AS Text) AS myStr
`,
query.WithParameters(
ydb.ParamsBuilder().
Param("$id").Uint64(123).
Expand Down Expand Up @@ -309,13 +317,17 @@
}
defer db.Close(ctx) // cleanup resources
var (
id int32 // required value
id uint64 // required value
myStr string // required value
)
// Do retry operation on errors with best effort
err = db.Query().Do(ctx, func(ctx context.Context, s query.Session) error {
streamResult, err := s.Query(ctx, // context manage exiting from Do
`SELECT CAST($id AS Uint64) AS id, CAST($myStr AS Text) AS myStr`,
`
DECLARE $id AS Uint64;
DECLARE $myStr AS Text;
SELECT CAST($id AS Uint64) AS id, CAST($myStr AS Text) AS myStr
`,
query.WithParameters(
ydb.ParamsBuilder().
Param("$id").Uint64(123).
Expand Down Expand Up @@ -367,7 +379,7 @@
}
defer db.Close(ctx) // cleanup resources
var (
id int32 // required value
id uint64 // required value
myStr string // optional value
)
// Do retry operation on errors with best effort
Expand Down Expand Up @@ -424,7 +436,7 @@
}
defer db.Close(ctx) // cleanup resources
var (
id int32 // required value
id uint64 // required value
myStr string // optional value
)
// Do retry operation on errors with best effort
Expand Down Expand Up @@ -476,9 +488,13 @@
if err != nil {
panic(err)
}
defer db.Close(ctx) // cleanup resources
defer db.Close(ctx) // cleanup resources

Check failure on line 491 in query/example_test.go

View workflow job for this annotation

GitHub Actions / golangci-lint 

File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/ydb-platform/ydb-go-sdk/v3) (gci)
op, err := db.Query().ExecuteScript(ctx, // context manage exiting from Do
`SELECT CAST($id AS Uint64) AS id, CAST($myStr AS Text) AS myStr`,
`
DECLARE $id AS Uint64;
DECLARE $myStr AS Text;
SELECT CAST($id AS Uint64) AS id, CAST($myStr AS Text) AS myStr
`,
time.Hour,
query.WithParameters(
ydb.ParamsBuilder().
Expand Down Expand Up @@ -519,7 +535,7 @@
panic(err)
}
var (
id int64
id uint64
myStr string
)
err = row.Scan(&id, &myStr)
Expand Down
Loading