Logging improvements for topic reader & writer#359
Merged
Conversation
Ids don't have to be unique. Its just for log observation convenience
alex268
approved these changes
Jan 23, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
============================================
+ Coverage 57.65% 57.72% +0.07%
Complexity 2055 2055
============================================
Files 311 311
Lines 12548 12550 +2
Branches 1245 1245
============================================
+ Hits 7235 7245 +10
+ Misses 4720 4712 -8
Partials 593 593 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
[9ka8R7.1/2-p8] Received StartPartitionSessionRequest for Topic "ydb-test/test-topic" and Consumer "/ydb-test/test-consumer". Partition session 2 (partition 8) with committedOffset 173587 and partitionOffsets [173587-173587)9ka8R7: reader generated random id1: stream id (increments with each reconnect)2: Partition session id. Set by serverp8: partition id (8)