-
Notifications
You must be signed in to change notification settings - Fork 28
Add equals() and hashCode() methods to topic description classes #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Eistern
wants to merge
8
commits into
ydb-platform:master
Choose a base branch
from
Eistern:feature/equals-hashcode-for-descriptions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add equals() and hashCode() methods to topic description classes #480
Eistern
wants to merge
8
commits into
ydb-platform:master
from
Eistern:feature/equals-hashcode-for-descriptions
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add equals implementations for topic description classes
Dependent on the #476 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #480 +/- ##
============================================
- Coverage 58.76% 58.28% -0.48%
- Complexity 2170 2178 +8
============================================
Files 320 323 +3
Lines 12942 13159 +217
Branches 1269 1318 +49
============================================
+ Hits 7605 7670 +65
- Misses 4720 4866 +146
- Partials 617 623 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces proper equals() and hashCode() implementations to classes used during topic description operations. These implementations follow standard Java equality contract patterns and allow for reliable comparison of description objects.