Skip to content

add maven wrapper #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

isopov
Copy link

@isopov isopov commented Jul 15, 2025

Currently maven wrapper is official part of the maven project - https://maven.apache.org/tools/wrapper/index.html - and not some third party tool as it was several years ago. Usability improvements should be great - no need to install is locally. How about adding it to the repo?

AFAIU there are many maven-based java repos in this project, same logic applies to all other as well, but lets use this PR as a place to discuss adding maven wrapper to all of them.

@alex268 alex268 self-requested a review July 15, 2025 12:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.30%. Comparing base (557f1e0) to head (82702a9).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #520   +/-   ##
=========================================
  Coverage     61.29%   61.30%           
- Complexity     2306     2307    +1     
=========================================
  Files           328      328           
  Lines         13468    13468           
  Branches       1344     1344           
=========================================
+ Hits           8255     8256    +1     
+ Misses         4578     4577    -1     
  Partials        635      635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants