Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prefix with POD_NAME in --grpc-public-host arg #296

Merged
merged 6 commits into from
Feb 24, 2025
Merged

Fix prefix with POD_NAME in --grpc-public-host arg #296

merged 6 commits into from
Feb 24, 2025

Conversation

kobzonega
Copy link
Contributor

@kobzonega kobzonega commented Feb 23, 2025 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • missing $(POD_NAME) prefix for --grpc-public-host arg

What is the new behavior?

  • adding the $(POD_NAME) prefix if it nor $(NODE_NAME) present in the annotation ydb.tech/grpc-public-host

Other information

@kobzonega kobzonega force-pushed the fix-grpc-public-host-arg branch from 399d4fc to 1a54fb7 Compare February 23, 2025 14:36
@kobzonega kobzonega requested a review from shmel1k February 24, 2025 02:51
@kobzonega kobzonega merged commit b2d3704 into master Feb 24, 2025
3 checks passed
@kobzonega kobzonega deleted the fix-grpc-public-host-arg branch February 24, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmel1k shmel1k shmel1k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobzonega @shmel1k