Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault in Group Layout Sanitizer, add stress tests with INACTIVE/FAULTY disks #15516

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

serbel324
Copy link
Collaborator

@serbel324 serbel324 commented Mar 10, 2025

Changelog entry

Fix bug when sanitizer caused nullptr dereference #15519
Add stress tests for sanitizer with INACTIVE/FAULTY statuses

Changelog category

  • Bugfix

Copy link

github-actions bot commented Mar 10, 2025

🟢 2025-03-10 12:11:29 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 10, 2025

2025-03-10 11:02:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 459105f has started.
2025-03-10 11:02:26 UTC Artifacts will be uploaded here
2025-03-10 11:05:15 UTC ya make is running...
🟡 2025-03-10 12:03:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19253 17915 0 3 1220 115

2025-03-10 12:05:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-10 12:18:20 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
169 (only retried tests) 64 0 0 0 105

🟢 2025-03-10 12:18:29 UTC Build successful.
🟢 2025-03-10 12:18:51 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 08a830d merge: 459105f diff diff %
ydbd size 2 293 856 560 Bytes 2 293 856 560 Bytes 0 Bytes 0.000%
ydbd stripped size 480 432 384 Bytes 480 432 384 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 10, 2025

2025-03-10 11:03:44 UTC Pre-commit check linux-x86_64-release-asan for 459105f has started.
2025-03-10 11:03:59 UTC Artifacts will be uploaded here
2025-03-10 11:06:45 UTC ya make is running...
🟡 2025-03-10 12:13:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11781 11576 0 157 12 36

2025-03-10 12:14:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-10 12:29:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
302 (only retried tests) 231 0 37 1 33

2025-03-10 12:29:19 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-10 12:51:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
136 (only retried tests) 84 0 21 0 31

🟢 2025-03-10 12:51:16 UTC Build successful.
🟢 2025-03-10 12:51:46 UTC ydbd size 3.7 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 08a830d merge: 459105f diff diff %
ydbd size 3 994 884 584 Bytes 3 994 884 504 Bytes -80 Bytes -0.000%
ydbd stripped size 1 388 591 688 Bytes 1 388 591 624 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@serbel324 serbel324 linked an issue Mar 10, 2025 that may be closed by this pull request
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 10, 2025
@serbel324 serbel324 linked an issue Mar 10, 2025 that may be closed by this pull request
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 10, 2025
Copy link

github-actions bot commented Mar 10, 2025

2025-03-10 13:00:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 54b0944 has started.
2025-03-10 13:00:27 UTC Artifacts will be uploaded here
2025-03-10 13:03:14 UTC ya make is running...
🟡 2025-03-10 13:53:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19253 17916 0 3 1218 116

2025-03-10 13:55:08 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-10 14:08:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 56 0 0 0 107

🟢 2025-03-10 14:08:39 UTC Build successful.
🟢 2025-03-10 14:09:01 UTC ydbd size 2.1 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3aaddf8 merge: 54b0944 diff diff %
ydbd size 2 293 856 560 Bytes 2 293 856 528 Bytes -32 Bytes -0.000%
ydbd stripped size 480 432 384 Bytes 480 432 320 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 10, 2025

2025-03-10 13:01:00 UTC Pre-commit check linux-x86_64-release-asan for 54b0944 has started.
2025-03-10 13:01:14 UTC Artifacts will be uploaded here
2025-03-10 13:03:58 UTC ya make is running...
🟡 2025-03-10 14:06:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11781 11555 0 174 15 37

2025-03-10 14:07:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-10 14:24:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
322 (only retried tests) 215 0 68 6 33

2025-03-10 14:24:46 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-10 14:37:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
185 (only retried tests) 110 0 40 5 30

🟢 2025-03-10 14:37:42 UTC Build successful.
🟢 2025-03-10 14:38:12 UTC ydbd size 3.7 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3aaddf8 merge: 54b0944 diff diff %
ydbd size 3 994 884 584 Bytes 3 994 884 552 Bytes -32 Bytes -0.000%
ydbd stripped size 1 388 591 688 Bytes 1 388 591 624 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@serbel324 serbel324 merged commit 89860e7 into ydb-platform:main Mar 11, 2025
12 checks passed
serbel324 added a commit to serbel324/ydb that referenced this pull request Mar 19, 2025
serbel324 added a commit to serbel324/ydb that referenced this pull request Mar 19, 2025
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INACTIVE disks cause segfault in group layout sanitizer Improve GroupLayoutSanitizer
2 participants