Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ADDINCL for C++ SDK #15655

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Conversation

Gazizonoki
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@Gazizonoki Gazizonoki requested review from a team as code owners March 12, 2025 17:44
@Gazizonoki Gazizonoki requested a review from vporyadke March 12, 2025 17:44
Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 17:46:35 UTC Pre-commit check linux-x86_64-release-asan for 218bc9d has started.
2025-03-12 17:46:50 UTC Artifacts will be uploaded here
🔴 2025-03-12 17:48:34 UTC Graph compare failed, see the logs.

Copy link

🟢 2025-03-12 17:47:07 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 17:48:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 218bc9d has started.
2025-03-12 17:49:03 UTC Artifacts will be uploaded here
🔴 2025-03-12 17:50:48 UTC Graph compare failed, see the logs.

Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 17:57:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 435619e has started.
2025-03-12 17:58:15 UTC Artifacts will be uploaded here
2025-03-12 18:01:56 UTC ya make is running...
🟡 2025-03-12 19:29:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28609 26009 0 2 2484 114

2025-03-12 19:32:12 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-12 19:45:46 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
177 (only retried tests) 71 0 0 0 106

🟢 2025-03-12 19:45:53 UTC Build successful.
🟢 2025-03-12 19:46:11 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: ee06b69 merge: 435619e diff diff %
ydbd size 2 298 155 960 Bytes 2 298 155 960 Bytes 0 Bytes 0.000%
ydbd stripped size 481 074 976 Bytes 481 074 976 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 17:58:16 UTC Pre-commit check linux-x86_64-release-asan for 435619e has started.
2025-03-12 17:58:31 UTC Artifacts will be uploaded here
2025-03-12 18:01:53 UTC ya make is running...
🟡 2025-03-12 19:49:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14213 14066 0 93 20 34

2025-03-12 19:50:16 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-12 20:03:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 160 0 0 2 32

🟢 2025-03-12 20:03:27 UTC Build successful.
🟢 2025-03-12 20:03:53 UTC ydbd size 3.8 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: ee06b69 merge: 435619e diff diff %
ydbd size 4 044 934 984 Bytes 4 044 934 888 Bytes -96 Bytes -0.000%
ydbd stripped size 1 399 611 144 Bytes 1 399 611 080 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Gazizonoki Gazizonoki enabled auto-merge (squash) March 12, 2025 18:18
@Gazizonoki Gazizonoki merged commit 81bb0df into ydb-platform:main Mar 12, 2025
12 checks passed
@Gazizonoki Gazizonoki deleted the addincl-sdk-remove branch March 12, 2025 20:09
@Enjection Enjection removed the request for review from vporyadke March 12, 2025 20:09
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Emgariko pushed a commit to Emgariko/ydb that referenced this pull request Mar 24, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants