Added parameters for YQL CREATE TRANSFER #15770
Conversation
|
🟢 |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
nshestakov
requested review from
CyberROFL and
uniquelogin
and removed request for
a team
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
…ze, consumer_name <ydb-platform#15770> commit_hash:f9e7a01a29938b4bec4aacdaa4e116101326f7da
| const auto result = session.ExecuteSchemeQuery(query).GetValueSync(); | ||
| UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::GENERIC_ERROR, result.GetIssues().ToString()); | ||
| UNIT_ASSERT_STRING_CONTAINS(result.GetIssues().ToOneLineString(), "consumer must be not empty"); | ||
| } |
There was a problem hiding this comment.
можно написать юнит тест который создаст трансфер с использованием query service? https://github.com/ydb-platform/ydb/blob/main/ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp#L6074
…ze, consumer_name <#15770> commit_hash:f9e7a01a29938b4bec4aacdaa4e116101326f7da
…ze, consumer_name <ydb-platform#15770> commit_hash:f9e7a01a29938b4bec4aacdaa4e116101326f7da
…ze, consumer_name <ydb-platform#15770> commit_hash:f9e7a01a29938b4bec4aacdaa4e116101326f7da
Changelog entry
...
Changelog category
Description for reviewers
Тут меняю proto без обратной совместимости, но эта функциональность еще никуда не выехала, и нигде не используется, только в тестах. Т.е. никому ничего не сломаю.
Основная идея замены repeated Targets на optional Target - это то, что всегда будет по одному таргету в трансфере. Заложенной возможности сделать несколько уже не получится т.к. таким транфером будет сложно управлять через YQL.