Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LookupJoin visualization in SVG (for DS) #15789

Merged
merged 1 commit into from
Mar 17, 2025
Merged

LookupJoin visualization in SVG (for DS) #15789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 64 additions & 28 deletions ydb/public/lib/ydb_cli/common/plan2svg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,23 @@ TSingleMetric::TSingleMetric(std::shared_ptr<TSummaryMetric> summary, ui64 value
Summary->Add(Details.Sum);
}

TString ParseColumns(const NJson::TJsonValue* node) {
TStringBuilder builder;
builder << '(';
if (node) {
bool firstColumn = true;
for (const auto& subNode : node->GetArray()) {
if (firstColumn) {
firstColumn = false;
} else {
builder << ", ";
}
builder << subNode.GetStringSafe();
}
}
builder << ')';
return builder;
}

void TPlan::Load(const NJson::TJsonValue& node) {
if (auto* subplanNameNode = node.GetValueByPath("Subplan Name")) {
Expand Down Expand Up @@ -514,10 +531,16 @@ void TPlan::LoadStage(std::shared_ptr<TStage> stage, const NJson::TJsonValue& no
TStringBuilder builder;

if (name == "Iterator" || name == "Member" || name == "ToFlow") {
if (auto* referenceNode = subNode.GetValueByPath(name)) {
auto referenceName = referenceNode->GetStringSafe();
references.insert(referenceName);
info = referenceName;
auto cteRef = "CTE " + referenceName;
auto stageCopy = stage;
MemberRefs.emplace_back(cteRef, std::make_pair<std::shared_ptr<TStage>, ui32>(std::move(stageCopy), stage->Operators.size()));
}
name = "Reference";
}

if (name == "Limit") {
} else if (name == "Limit") {
if (auto* limitNode = subNode.GetValueByPath("Limit")) {
info = limitNode->GetStringSafe();
}
Expand Down Expand Up @@ -644,19 +667,7 @@ void TPlan::LoadStage(std::shared_ptr<TStage> stage, const NJson::TJsonValue& no
}
builder << table;
}
builder << "(";
if (auto* readColumnsNode = subNode.GetValueByPath("ReadColumns")) {
bool firstColumn = true;
for (const auto& subNode : readColumnsNode->GetArray()) {
if (firstColumn) {
firstColumn = false;
} else {
builder << ", ";
}
builder << subNode.GetStringSafe();
}
}
builder << ")";
builder << ParseColumns(subNode.GetValueByPath("ReadColumns"));
info = builder;
externalOperator = true;
} else if (name == "TopSort" || name == "Top") {
Expand All @@ -677,23 +688,14 @@ void TPlan::LoadStage(std::shared_ptr<TStage> stage, const NJson::TJsonValue& no
}
}
info = builder;
} else if (name == "Reference") {
if (auto* referenceNode = subNode.GetValueByPath(name)) {
auto referenceName = referenceNode->GetStringSafe();
references.insert(referenceName);
info = referenceName;
auto cteRef = "CTE " + referenceName;
auto stageCopy = stage;
MemberRefs.emplace_back(cteRef, std::make_pair<std::shared_ptr<TStage>, ui32>(std::move(stageCopy), stage->Operators.size()));
}
} else if (name.Contains("Join")) {
operatorType = "Join";
if (auto* conditionNode = subNode.GetValueByPath("Condition")) {
info = conditionNode->GetStringSafe();
}
}

if (externalOperator) {
if (externalOperator && !stage->External) {
externalOperators.emplace_back(name, info);
externalOperators.back().Estimations = GetEstimation(subNode);
} else {
Expand Down Expand Up @@ -789,7 +791,7 @@ void TPlan::LoadStage(std::shared_ptr<TStage> stage, const NJson::TJsonValue& no
}
}

if (!externalOperators.empty()) {
if (!externalOperators.empty() && !stage->External) {
auto connection = std::make_shared<TConnection>(*stage, "External", 0);
stage->Connections.push_back(connection);
Stages.push_back(std::make_shared<TStage>("External"));
Expand Down Expand Up @@ -853,7 +855,8 @@ void TPlan::LoadStage(std::shared_ptr<TStage> stage, const NJson::TJsonValue& no
if (auto* outputNode = stage->StatsNode->GetValueByPath("Output")) {
for (const auto& subNode : outputNode->GetArray()) {
if (auto* nameNode = subNode.GetValueByPath("Name")) {
if (ToString(parentPlanNodeId) == nameNode->GetStringSafe()) {
auto name = nameNode->GetStringSafe();
if (name == ToString(parentPlanNodeId) || name == "RESULT") {
if (auto* popNode = subNode.GetValueByPath("Pop")) {
if (auto* bytesNode = popNode->GetValueByPath("Bytes")) {
stage->OutputBytes = std::make_shared<TSingleMetric>(OutputBytes,
Expand Down Expand Up @@ -917,6 +920,26 @@ void TPlan::LoadStage(std::shared_ptr<TStage> stage, const NJson::TJsonValue& no
}

if (planNodeType == "Connection") {
if (subNodeType == "TableLookup") {
// "TableLookup" => "Table" + "Lookup"
auto connection = std::make_shared<TConnection>(*stage, "Lookup", stage->PlanNodeId);
stage->Connections.push_back(connection);
Stages.push_back(std::make_shared<TStage>("External"));
connection->FromStage = Stages.back();
Stages.back()->External = true;
TStringBuilder builder;
if (auto* tableNode = plan.GetValueByPath("Table")) {
auto table = tableNode->GetStringSafe();
auto n = table.find_last_of('/');
if (n != table.npos) {
table = table.substr(n + 1);
}
builder << table;
}
builder << ParseColumns(plan.GetValueByPath("Columns")) << " by " << ParseColumns(plan.GetValueByPath("LookupKeyColumns"));
Stages.back()->Operators.emplace_back("TableLookup", builder);
subNodeType = "Table";
}
auto* keyColumnsNode = plan.GetValueByPath("KeyColumns");
auto* sortColumnsNode = plan.GetValueByPath("SortColumns");
if (auto* subNode = plan.GetValueByPath("Plans")) {
Expand Down Expand Up @@ -1027,6 +1050,17 @@ void TPlan::LoadStage(std::shared_ptr<TStage> stage, const NJson::TJsonValue& no
}
}
LoadSource(plan, stage->Operators, ingressRowsNode);
} else if (subNodeType == "TableFullScan") {
if (stage->IngressName) {
ythrow yexception() << "Plan stage already has Ingress [" << stage->IngressName << "]";
}
stage->IngressName = subNodeType;
auto connection = std::make_shared<TConnection>(*stage, "External", 0);
stage->Connections.push_back(connection);
Stages.push_back(std::make_shared<TStage>("External"));
connection->FromStage = Stages.back();
Stages.back()->External = true;
LoadStage(Stages.back(), plan, stage->PlanNodeId);
} else {
stage->Connections.push_back(std::make_shared<TConnection>(*stage, "Implicit", stage->PlanNodeId));
Stages.push_back(std::make_shared<TStage>(subNodeType));
Expand Down Expand Up @@ -1822,6 +1856,8 @@ void TPlan::PrintSvg(ui64 maxTime, ui32& offsetY, TStringBuilder& background, TS
else if (c->NodeType == "UnionAll") mark = "U";
else if (c->NodeType == "Broadcast") mark = "B";
else if (c->NodeType == "External") mark = "E";
else if (c->NodeType == "Table") mark = "T";
else if (c->NodeType == "Lookup") mark = "L";
else mark = "?";

canvas
Expand Down
Loading