Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set field Engine to 1 to maintain backward compatibility #15878

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

aavdonkin
Copy link
Collaborator

@aavdonkin aavdonkin commented Mar 18, 2025

Changelog entry

Initialize field Engine before write to local database, to make possible to work by branch stable-24-3-15
...

Changelog category

  • Bugfix

Description for reviewers

...

@aavdonkin aavdonkin requested review from a team as code owners March 18, 2025 11:30
Copy link

github-actions bot commented Mar 18, 2025

🟢 2025-03-18 12:14:39 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 18, 2025

2025-03-18 11:31:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for bd21ba7 has started.
2025-03-18 11:32:54 UTC Artifacts will be uploaded here
2025-03-18 11:36:34 UTC ya make is running...
🟡 2025-03-18 13:14:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28517 25914 0 5 2481 117

2025-03-18 13:16:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-18 13:36:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
175 (only retried tests) 61 0 3 3 108

2025-03-18 13:36:19 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-18 14:04:06 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
157 (only retried tests) 46 0 3 1 107

🟢 2025-03-18 14:04:13 UTC Build successful.
🟢 2025-03-18 14:04:38 UTC ydbd size 2.1 GiB changed* by +15.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 31b3314 merge: bd21ba7 diff diff %
ydbd size 2 299 410 176 Bytes 2 299 426 224 Bytes +15.7 KiB +0.001%
ydbd stripped size 481 262 848 Bytes 481 263 744 Bytes +896 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 18, 2025

2025-03-18 11:34:02 UTC Pre-commit check linux-x86_64-release-asan for bd21ba7 has started.
2025-03-18 11:34:18 UTC Artifacts will be uploaded here
2025-03-18 11:37:36 UTC ya make is running...
🟡 2025-03-18 13:24:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14060 13960 0 40 21 39

2025-03-18 13:25:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-18 13:39:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
148 (only retried tests) 104 0 0 5 39

🟢 2025-03-18 13:39:22 UTC Build successful.
🟢 2025-03-18 13:39:55 UTC ydbd size 3.8 GiB changed* by +26.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 31b3314 merge: bd21ba7 diff diff %
ydbd size 4 048 575 752 Bytes 4 048 603 336 Bytes +26.9 KiB +0.001%
ydbd stripped size 1 400 532 840 Bytes 1 400 537 512 Bytes +4.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@aavdonkin aavdonkin linked an issue Mar 18, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Mar 18, 2025

2025-03-18 14:52:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3d36317 has started.
2025-03-18 14:52:36 UTC Artifacts will be uploaded here
2025-03-18 14:55:50 UTC ya make is running...
🟡 2025-03-18 16:31:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28533 25923 0 3 2489 118

2025-03-18 16:34:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-18 16:50:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
173 (only retried tests) 61 0 0 1 111

🟢 2025-03-18 16:50:24 UTC Build successful.
🟢 2025-03-18 16:50:47 UTC ydbd size 2.1 GiB changed* by +15.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 116e45b merge: 3d36317 diff diff %
ydbd size 2 300 087 704 Bytes 2 300 103 816 Bytes +15.7 KiB +0.001%
ydbd stripped size 481 400 768 Bytes 481 401 728 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 18, 2025

2025-03-18 14:55:04 UTC Pre-commit check linux-x86_64-release-asan for 3d36317 has started.
2025-03-18 14:55:37 UTC Artifacts will be uploaded here
2025-03-18 14:59:19 UTC ya make is running...
🟡 2025-03-18 16:34:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14066 13984 0 28 16 38

2025-03-18 16:35:51 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-18 16:48:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
128 (only retried tests) 80 0 1 11 36

2025-03-18 16:48:51 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-18 17:06:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79 (only retried tests) 40 0 1 4 34

🟢 2025-03-18 17:06:14 UTC Build successful.
🟢 2025-03-18 17:06:48 UTC ydbd size 3.8 GiB changed* by +23.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 116e45b merge: 3d36317 diff diff %
ydbd size 4 049 843 600 Bytes 4 049 867 280 Bytes +23.1 KiB +0.001%
ydbd stripped size 1 401 009 640 Bytes 1 401 010 280 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@aavdonkin aavdonkin self-assigned this Mar 19, 2025
@aavdonkin aavdonkin merged commit 749b883 into ydb-platform:main Mar 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

24-3-15 can not start after main
3 participants