Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restored test checking quota exhaustion #15968

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Restored test checking quota exhaustion #15968

wants to merge 2 commits into from
+37 −17

Conversation

aavdonkin
Copy link
Collaborator

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • User Interface
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2025 •
edited
Loading

⚪ 2025-03-19 14:32:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9dfb2e4 has started.
⚪ 2025-03-19 14:32:56 UTC Artifacts will be uploaded here
⚪ 2025-03-19 14:35:53 UTC ya make is running...
🟡 2025-03-19 14:48:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79 68 0 1 5 5

⚪ 2025-03-19 14:48:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-19 15:06:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12 (only retried tests) 7 0 1 1 3

⚪ 2025-03-19 15:06:20 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-19 15:27:33 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6 (only retried tests) 3 0 1 0 2

🟢 2025-03-19 15:27:44 UTC Build successful.
🟢 2025-03-19 15:27:58 UTC ydbd size 2.1 GiB changed* by +176 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8ab3977 merge: 9dfb2e4 diff diff %
ydbd size 2 301 025 632 Bytes 2 301 025 808 Bytes +176 Bytes +0.000%
ydbd stripped size 481 570 560 Bytes 481 570 624 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

🟢 2025-03-19 14:33:04 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2025 •
edited
Loading

⚪ 2025-03-19 14:34:51 UTC Pre-commit check linux-x86_64-release-asan for 9dfb2e4 has started.
⚪ 2025-03-19 14:35:23 UTC Artifacts will be uploaded here
⚪ 2025-03-19 14:38:06 UTC ya make is running...
🟡 2025-03-19 14:57:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 44 0 1 10 7

⚪ 2025-03-19 14:57:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-19 15:11:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 7 0 1 3 9

⚪ 2025-03-19 15:11:20 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-19 15:29:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 6 0 1 3 4

🟢 2025-03-19 15:29:21 UTC Build successful.
🟢 2025-03-19 15:29:38 UTC ydbd size 3.8 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8ab3977 merge: 9dfb2e4 diff diff %
ydbd size 4 051 465 528 Bytes 4 051 465 448 Bytes -80 Bytes -0.000%
ydbd stripped size 1 401 500 872 Bytes 1 401 500 808 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2025 •
edited
Loading

⚪ 2025-03-19 15:44:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7f0d09c has started.
⚪ 2025-03-19 15:45:22 UTC Artifacts will be uploaded here
⚪ 2025-03-19 15:48:09 UTC ya make is running...
🟡 2025-03-19 16:16:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79 65 0 1 7 6

⚪ 2025-03-19 16:16:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-19 16:31:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15 (only retried tests) 10 0 0 1 4

🟢 2025-03-19 16:31:24 UTC Build successful.
🟠 2025-03-19 16:33:43 UTC Unmuted 1 tests
🟢 2025-03-19 16:33:54 UTC ydbd size 2.1 GiB changed* by +9.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a95cd74 merge: 7f0d09c diff diff %
ydbd size 2 301 025 808 Bytes 2 301 035 328 Bytes +9.3 KiB +0.000%
ydbd stripped size 481 570 624 Bytes 481 572 864 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2025 •
edited
Loading

⚪ 2025-03-19 15:45:55 UTC Pre-commit check linux-x86_64-release-asan for 7f0d09c has started.
⚪ 2025-03-19 15:46:09 UTC Artifacts will be uploaded here
⚪ 2025-03-19 15:48:21 UTC ya make is running...
🟡 2025-03-19 16:00:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 47 0 1 8 6

⚪ 2025-03-19 16:00:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-19 16:12:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 (only retried tests) 3 0 1 6 6

⚪ 2025-03-19 16:12:17 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-19 16:33:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15 (only retried tests) 5 0 1 3 6

🟢 2025-03-19 16:33:59 UTC Build successful.
🟢 2025-03-19 16:34:14 UTC ydbd size 3.8 GiB changed* by +17.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a95cd74 merge: 7f0d09c diff diff %
ydbd size 4 051 465 544 Bytes 4 051 483 856 Bytes +17.9 KiB +0.000%
ydbd stripped size 1 401 500 872 Bytes 1 401 507 400 Bytes +6.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

dorooleg
dorooleg reviewed Mar 20, 2025
View reviewed changes
ydb/tests/olap/test_quota_exhaustion.py
@@ -7,8 +7,8 @@
from ydb.tests.library.harness.kikimr_runner import KiKiMR
from ydb.tests.library.test_meta import link_test_case

ROWS_CHUNK_SIZE = 3000000
ROWS_CHUNKS_COUNT = 100000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему тут понадобилось значения менять?

dorooleg
dorooleg reviewed Mar 20, 2025
View reviewed changes
ydb/tests/olap/test_quota_exhaustion.py

@link_test_case("#13529")
def test(self):
"""As per https://github.com/ydb-platform/ydb/issues/13529"""
self.database_name = '/Root'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вынеси self.database_name на уровень класса по аналогии с этим примером

dorooleg
dorooleg reviewed Mar 20, 2025
View reviewed changes
ydb/tests/olap/test_quota_exhaustion.py
},
)
self.cluster.register_and_start_slots(self.database_name, count=1)
self.cluster.wait_tenant_up(self.database_name)

# Set soft and hard quotas to 6GB
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут комменатрий стал не актуален про 6 GB, а уменьшил это значение чтобы тест быстрее проходил?

dorooleg
dorooleg reviewed Mar 20, 2025
View reviewed changes
ydb/tests/olap/test_quota_exhaustion.py

# Check that deletion works at least first time
# self.delete_test_chunk(session, 'huge', 0)
self.delete_test_chunk(session, table_path, 0)
# ^ uncomment after fixing https://github.com/ydb-platform/ydb/issues/13808
Copy link
Collaborator

@dorooleg dorooleg Mar 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Комментарий можно убирать?

dorooleg
dorooleg reviewed Mar 20, 2025
View reviewed changes
ydb/tests/olap/test_quota_exhaustion.py

# Try to wait until deletion works again (after compaction)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Напиши комментарий что это в отдельном ревью будет проверяться

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorooleg dorooleg dorooleg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aavdonkin @dorooleg