Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check ActorLibCollectUsageStats to reduce utils metric count #15992

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kardymonds
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copy link

🟢 2025-03-20 07:25:13 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 20, 2025

2025-03-20 07:25:19 UTC Pre-commit check linux-x86_64-release-asan for 38aec12 has started.
2025-03-20 07:25:33 UTC Artifacts will be uploaded here
2025-03-20 07:28:28 UTC ya make is running...
🟡 2025-03-20 08:37:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14119 14022 0 49 11 37

2025-03-20 08:39:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-20 08:51:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
145 (only retried tests) 105 0 1 5 34

2025-03-20 08:51:40 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-20 09:10:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 31 0 0 3 32

🟢 2025-03-20 09:10:27 UTC Build successful.
🟢 2025-03-20 09:10:56 UTC ydbd size 3.8 GiB changed* by -20.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 19deb54 merge: 38aec12 diff diff %
ydbd size 4 052 803 592 Bytes 4 052 782 296 Bytes -20.8 KiB -0.001%
ydbd stripped size 1 401 813 192 Bytes 1 401 806 216 Bytes -6.8 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 20, 2025

2025-03-20 07:28:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 38aec12 has started.
2025-03-20 07:28:45 UTC Artifacts will be uploaded here
2025-03-20 07:31:39 UTC ya make is running...
🟡 2025-03-20 08:31:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28654 26025 0 10 2498 121

2025-03-20 08:34:09 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-20 08:52:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 82 0 0 2 108

🟢 2025-03-20 08:52:13 UTC Build successful.
🟢 2025-03-20 08:52:36 UTC ydbd size 2.1 GiB changed* by -9.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 089a262 merge: 38aec12 diff diff %
ydbd size 2 301 855 120 Bytes 2 301 845 664 Bytes -9.2 KiB -0.000%
ydbd stripped size 481 672 320 Bytes 481 670 016 Bytes -2.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@@ -361,7 +361,7 @@ namespace NActors {
Y_DEBUG_ABORT_UNLESS(GetNextPtr(tail) == nullptr);
#ifdef ACTORSLIB_COLLECT_EXEC_STATS
// Mark events as enqueued when usage stats are enabled
if (ActorLibCollectUsageStats) {
if constexpr (ActorLibCollectUsageStats) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static constexpr bool ActorLibCollectUsageStats = false;
https://github.com/ydb-platform/ydb/blob/main/ydb/library/actors/core/defs.h#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant