Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable inflight limit for ReadRows gRPC call #16014

Open
wants to merge 1 commit into
base: stream-nb-24-3
Choose a base branch
from

Conversation

SammyVimes
Copy link
Collaborator

The limit is required to prevent dynnodes crashes by OOM when the network capacity is not enough to transport requested data to the client via ReadRows gRPC API.

The limit is configurable, default value is 0 (unlimited) for backward compatibility.

(cherry picked from commit 773d088)

Copy link

github-actions bot commented Mar 20, 2025

2025-03-20 13:05:54 UTC Pre-commit check for b8f9035 has started.
2025-03-20 13:09:03 UTC Build linux-x86_64-release-asan is running...
🟢 2025-03-20 13:58:21 UTC Build successful.
2025-03-20 13:58:37 UTC Tests are running...
🔴 2025-03-20 16:13:31 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11921 11804 0 41 30 46

🟡 2025-03-20 16:14:23 UTC ydbd size 5.6 GiB changed* by +707.6 KiB, which is >= 100.0 KiB vs stream-nb-24-3: Warning

ydbd size dash stream-nb-24-3: 3ecc78c merge: b8f9035 diff diff %
ydbd size 6 012 599 088 Bytes 6 013 323 640 Bytes +707.6 KiB +0.012%
ydbd stripped size 1 506 025 152 Bytes 1 506 198 848 Bytes +169.6 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 20, 2025

2025-03-20 13:51:06 UTC Pre-commit check for b8f9035 has started.
2025-03-20 13:54:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-03-20 15:08:31 UTC Build successful.
2025-03-20 15:09:45 UTC Tests are running...
🔴 2025-03-20 17:06:55 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40513 35235 0 19 5218 41

🟡 2025-03-20 17:07:59 UTC ydbd size 8.3 GiB changed* by +604.5 KiB, which is >= 100.0 KiB vs stream-nb-24-3: Warning

ydbd size dash stream-nb-24-3: 3ecc78c merge: b8f9035 diff diff %
ydbd size 8 883 603 128 Bytes 8 884 222 112 Bytes +604.5 KiB +0.007%
ydbd stripped size 484 279 208 Bytes 484 317 128 Bytes +37.0 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant