Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a connector based on a request's data source kind #16052

Merged
merged 6 commits into from
Mar 26, 2025

Conversation

buhtr
Copy link
Collaborator

@buhtr buhtr commented Mar 21, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Client GRPC choose what connector to use by judging a request's data source kind

@buhtr buhtr requested review from a team as code owners March 21, 2025 10:58
@buhtr buhtr requested review from vitalyisaev2 and uzhastik March 21, 2025 10:58
Copy link

🟢 2025-03-21 10:59:23 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 21, 2025

2025-03-21 10:59:35 UTC Pre-commit check linux-x86_64-release-asan for 242bc7b has started.
2025-03-21 10:59:41 UTC Artifacts will be uploaded here
2025-03-21 11:02:28 UTC ya make is running...
🟡 2025-03-21 12:28:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13877 13804 0 26 11 36

2025-03-21 12:29:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-21 12:41:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 65 0 4 3 34

2025-03-21 12:42:05 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-21 12:55:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 32 0 3 2 32

🟢 2025-03-21 12:55:42 UTC Build successful.
🟢 2025-03-21 12:56:13 UTC ydbd size 3.8 GiB changed* by +48.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6dc2e21 merge: 242bc7b diff diff %
ydbd size 4 073 892 992 Bytes 4 073 942 208 Bytes +48.1 KiB +0.001%
ydbd stripped size 1 409 061 352 Bytes 1 409 076 840 Bytes +15.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 21, 2025

2025-03-21 10:59:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 242bc7b has started.
2025-03-21 11:00:00 UTC Artifacts will be uploaded here
2025-03-21 11:02:54 UTC ya make is running...
🟡 2025-03-21 12:20:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28322 25664 0 12 2531 115

2025-03-21 12:23:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-21 12:40:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
210 (only retried tests) 76 0 3 24 107

2025-03-21 12:40:11 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-21 12:54:07 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
174 (only retried tests) 42 0 3 24 105

🟢 2025-03-21 12:54:18 UTC Build successful.
🟢 2025-03-21 12:54:42 UTC ydbd size 2.2 GiB changed* by +34.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6dc2e21 merge: 242bc7b diff diff %
ydbd size 2 314 348 712 Bytes 2 314 383 648 Bytes +34.1 KiB +0.002%
ydbd stripped size 484 361 728 Bytes 484 368 000 Bytes +6.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@naspirato naspirato added the rebase-and-check Rebase PR with the current base branch and check label Mar 21, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Mar 21, 2025
Copy link

github-actions bot commented Mar 21, 2025

2025-03-21 17:39:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 555ffe1 has started.
2025-03-21 17:39:43 UTC Artifacts will be uploaded here
2025-03-21 17:42:29 UTC ya make is running...
🟡 2025-03-21 18:47:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28336 25728 0 3 2491 114

2025-03-21 18:49:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-21 19:00:57 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
159 (only retried tests) 54 0 0 0 105

🟢 2025-03-21 19:01:04 UTC Build successful.
🟢 2025-03-21 19:01:22 UTC ydbd size 2.2 GiB changed* by +34.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a95ce0d merge: 555ffe1 diff diff %
ydbd size 2 315 431 248 Bytes 2 315 466 248 Bytes +34.2 KiB +0.002%
ydbd stripped size 484 584 992 Bytes 484 591 328 Bytes +6.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 21, 2025

2025-03-21 19:31:39 UTC Pre-commit check linux-x86_64-release-asan for 555ffe1 has started.
2025-03-21 19:31:54 UTC Artifacts will be uploaded here
2025-03-21 19:34:41 UTC ya make is running...
🟡 2025-03-21 20:46:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13890 13800 0 46 11 33

2025-03-21 20:48:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-21 21:00:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
137 (only retried tests) 100 0 3 1 33

2025-03-21 21:01:04 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-21 21:12:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 31 0 3 0 30

🟢 2025-03-21 21:12:47 UTC Build successful.
🟢 2025-03-21 21:13:14 UTC ydbd size 3.8 GiB changed* by +52.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a95ce0d merge: 555ffe1 diff diff %
ydbd size 4 075 721 248 Bytes 4 075 774 560 Bytes +52.1 KiB +0.001%
ydbd stripped size 1 409 668 456 Bytes 1 409 688 040 Bytes +19.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 23, 2025

2025-03-23 13:17:41 UTC Pre-commit check linux-x86_64-release-asan for a1926d6 has started.
2025-03-23 13:17:57 UTC Artifacts will be uploaded here
2025-03-23 13:20:44 UTC ya make is running...
🟡 2025-03-23 14:41:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13897 13811 0 33 17 36

2025-03-23 14:42:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-23 14:54:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
128 (only retried tests) 86 0 3 5 34

2025-03-23 14:55:06 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-23 15:06:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 29 0 4 4 31

🟢 2025-03-23 15:06:48 UTC Build successful.
🟢 2025-03-23 15:07:17 UTC ydbd size 3.8 GiB changed* by +59.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 222a367 merge: a1926d6 diff diff %
ydbd size 4 081 211 840 Bytes 4 081 272 432 Bytes +59.2 KiB +0.001%
ydbd stripped size 1 410 078 280 Bytes 1 410 102 664 Bytes +23.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 23, 2025

2025-03-23 13:17:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for a1926d6 has started.
2025-03-23 13:18:01 UTC Artifacts will be uploaded here
2025-03-23 13:20:48 UTC ya make is running...
🟡 2025-03-23 14:35:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28348 25726 0 3 2498 121

2025-03-23 14:38:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-23 14:51:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
165 (only retried tests) 58 0 0 0 107

🟢 2025-03-23 14:51:31 UTC Build successful.
🟢 2025-03-23 14:51:49 UTC ydbd size 2.2 GiB changed* by +38.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 222a367 merge: a1926d6 diff diff %
ydbd size 2 319 772 368 Bytes 2 319 811 272 Bytes +38.0 KiB +0.002%
ydbd stripped size 484 954 080 Bytes 484 960 992 Bytes +6.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@buhtr buhtr force-pushed the feature/connection-for-kind branch from 223b3d3 to 974742a Compare March 24, 2025 10:07
Copy link

github-actions bot commented Mar 24, 2025

2025-03-24 10:10:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4dc5061 has started.
2025-03-24 10:10:53 UTC Artifacts will be uploaded here
2025-03-24 10:13:46 UTC ya make is running...
🟢 2025-03-24 11:27:35 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28348 25739 0 0 2495 114

🟢 2025-03-24 11:30:12 UTC Build successful.
🟢 2025-03-24 11:30:28 UTC ydbd size 2.2 GiB changed* by +35.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cffada5 merge: 4dc5061 diff diff %
ydbd size 2 319 873 376 Bytes 2 319 909 656 Bytes +35.4 KiB +0.002%
ydbd stripped size 484 966 432 Bytes 484 972 768 Bytes +6.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 24, 2025

2025-03-24 10:10:43 UTC Pre-commit check linux-x86_64-release-asan for 4dc5061 has started.
2025-03-24 10:10:58 UTC Artifacts will be uploaded here
2025-03-24 10:13:51 UTC ya make is running...
🟡 2025-03-24 11:37:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13897 13811 0 35 14 37

2025-03-24 11:38:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-24 11:51:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
123 (only retried tests) 83 0 4 3 33

2025-03-24 11:51:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-24 12:05:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 28 0 4 1 33

🟢 2025-03-24 12:05:37 UTC Build successful.
🟢 2025-03-24 12:06:07 UTC ydbd size 3.8 GiB changed* by +56.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cffada5 merge: 4dc5061 diff diff %
ydbd size 4 081 320 384 Bytes 4 081 378 312 Bytes +56.6 KiB +0.001%
ydbd stripped size 1 410 107 432 Bytes 1 410 131 368 Bytes +23.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

vitalyisaev2
vitalyisaev2 previously approved these changes Mar 24, 2025
Copy link

github-actions bot commented Mar 24, 2025

2025-03-24 15:24:28 UTC Pre-commit check linux-x86_64-release-asan for a3b8ba2 has started.
2025-03-24 15:24:44 UTC Artifacts will be uploaded here
2025-03-24 15:27:37 UTC ya make is running...
2025-03-24 15:30:06 UTC Check cancelled

Copy link

github-actions bot commented Mar 24, 2025

2025-03-24 15:24:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for a3b8ba2 has started.
2025-03-24 15:25:01 UTC Artifacts will be uploaded here
2025-03-24 15:27:52 UTC ya make is running...
2025-03-24 15:30:07 UTC Check cancelled

Copy link

github-actions bot commented Mar 24, 2025

2025-03-24 15:34:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7c840b9 has started.
2025-03-24 15:34:46 UTC Artifacts will be uploaded here
2025-03-24 15:37:43 UTC ya make is running...
🟡 2025-03-24 17:17:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28350 25734 0 9 2495 112

2025-03-24 17:20:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-24 17:34:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
166 (only retried tests) 62 0 0 0 104

🟢 2025-03-24 17:34:50 UTC Build successful.
🟡 2025-03-24 17:35:11 UTC ydbd size 2.2 GiB changed* by +183.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f081b8b merge: 7c840b9 diff diff %
ydbd size 2 319 979 616 Bytes 2 320 167 376 Bytes +183.4 KiB +0.008%
ydbd stripped size 484 993 312 Bytes 485 034 144 Bytes +39.9 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 24, 2025

2025-03-24 15:34:33 UTC Pre-commit check linux-x86_64-release-asan for 7c840b9 has started.
2025-03-24 15:34:48 UTC Artifacts will be uploaded here
2025-03-24 15:37:36 UTC ya make is running...
🟡 2025-03-24 17:29:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13899 13797 0 52 18 32

2025-03-24 17:30:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-24 17:43:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
151 (only retried tests) 113 0 6 3 29

2025-03-24 17:43:23 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-24 17:54:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 25 0 3 2 30

🟢 2025-03-24 17:55:03 UTC Build successful.
🟡 2025-03-24 17:55:34 UTC ydbd size 3.8 GiB changed* by +286.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7fb1600 merge: 7c840b9 diff diff %
ydbd size 4 081 544 320 Bytes 4 081 837 288 Bytes +286.1 KiB +0.007%
ydbd stripped size 1 410 187 144 Bytes 1 410 277 416 Bytes +88.2 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 25, 2025

2025-03-25 10:50:16 UTC Pre-commit check linux-x86_64-release-asan for 4a6b3c2 has started.
2025-03-25 10:50:33 UTC Artifacts will be uploaded here
2025-03-25 10:53:33 UTC ya make is running...
🟡 2025-03-25 12:20:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13904 13724 0 128 18 34

2025-03-25 12:22:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-25 12:43:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
226 (only retried tests) 186 0 4 5 31

2025-03-25 12:43:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-25 12:55:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 30 0 4 3 29

🟢 2025-03-25 12:55:56 UTC Build successful.
🟢 2025-03-25 12:56:26 UTC ydbd size 3.8 GiB changed* by +59.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a4d81e7 merge: 4a6b3c2 diff diff %
ydbd size 4 083 480 192 Bytes 4 083 541 432 Bytes +59.8 KiB +0.001%
ydbd stripped size 1 410 958 120 Bytes 1 410 985 640 Bytes +26.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 25, 2025

2025-03-25 10:50:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4a6b3c2 has started.
2025-03-25 10:50:55 UTC Artifacts will be uploaded here
2025-03-25 10:53:44 UTC ya make is running...
🟡 2025-03-25 12:09:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28404 25742 0 7 2542 113

2025-03-25 12:12:05 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-25 12:32:28 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
166 (only retried tests) 62 0 0 0 104

🟢 2025-03-25 12:32:38 UTC Build successful.
🟢 2025-03-25 12:32:58 UTC ydbd size 2.2 GiB changed* by +36.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a4d81e7 merge: 4a6b3c2 diff diff %
ydbd size 2 321 227 264 Bytes 2 321 264 408 Bytes +36.3 KiB +0.002%
ydbd stripped size 485 297 472 Bytes 485 307 456 Bytes +9.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@buhtr buhtr merged commit a53e924 into ydb-platform:main Mar 26, 2025
12 checks passed
vitalyisaev2 added a commit to vitalyisaev2/ydb that referenced this pull request Mar 27, 2025
@buhtr buhtr mentioned this pull request Mar 31, 2025
buhtr added a commit that referenced this pull request Mar 31, 2025
Co-authored-by: s2m1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants