Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix returning clause in upsert/insert on missing input columns #16060

Conversation

gridnevvvit
Copy link
Member

Changelog entry

fixes #15551

Changelog category

  • Bugfix

Description for reviewers

...

@gridnevvvit gridnevvvit requested a review from a team as a code owner March 21, 2025 11:36
Copy link

🟢 2025-03-21 11:37:16 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 21, 2025

2025-03-21 12:19:21 UTC Pre-commit check linux-x86_64-release-asan for 37c0776 has started.
2025-03-21 12:19:54 UTC Artifacts will be uploaded here
2025-03-21 12:23:22 UTC ya make is running...
🟡 2025-03-21 13:39:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12029 11881 0 98 14 36

2025-03-21 13:40:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-21 13:53:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
203 (only retried tests) 158 0 3 6 36

2025-03-21 13:53:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-21 14:07:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75 (only retried tests) 33 0 3 5 34

🟢 2025-03-21 14:07:13 UTC Build successful.
🟢 2025-03-21 14:07:43 UTC ydbd size 3.8 GiB changed* by +83.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6dc2e21 merge: 37c0776 diff diff %
ydbd size 4 073 892 992 Bytes 4 073 978 504 Bytes +83.5 KiB +0.002%
ydbd stripped size 1 409 061 352 Bytes 1 409 085 416 Bytes +23.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 21, 2025

2025-03-21 12:41:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 37c0776 has started.
2025-03-21 12:41:43 UTC Artifacts will be uploaded here
2025-03-21 12:45:15 UTC ya make is running...
🟡 2025-03-21 13:44:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19323 17937 0 7 1264 115

2025-03-21 13:46:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-21 13:58:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
205 (only retried tests) 99 0 1 0 105

2025-03-21 13:59:09 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-21 14:11:20 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
145 (only retried tests) 40 0 1 0 104

🟢 2025-03-21 14:11:27 UTC Build successful.
🟢 2025-03-21 14:11:47 UTC ydbd size 2.2 GiB changed* by +38.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6dc2e21 merge: 37c0776 diff diff %
ydbd size 2 314 348 712 Bytes 2 314 388 176 Bytes +38.5 KiB +0.002%
ydbd stripped size 484 361 728 Bytes 484 372 800 Bytes +10.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk merged commit 679f7fd into ydb-platform:main Mar 21, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RETURNING * does not work correctly with INSERT/UPSERT
3 participants