default value has been disabled for column tables #16088
Conversation
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
dorooleg
force-pushed
the
default_value_disabled
branch
from
6032c0d to
df17d99
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
|
||
| if (column.has_from_literal()) { | ||
| status = Ydb::StatusIds::BAD_REQUEST; | ||
| error = TStringBuilder() << "Default value from literal specified for column `" << column.name() << "` is not supported in cases of column tables"; |
There was a problem hiding this comment.
Я бы упростил до Default values are not supported in column tables
There was a problem hiding this comment.
Тогда может быть не понятно в какой колонке проблема. Тут могут использовать orm и прочие инструменты вокруг и в этом случае может быть сложно раздебажить, а в какой колоноке вообще default values появились
There was a problem hiding this comment.
И еще они двух видов бывают, наверное для дебага пользователю полезно получить информацию sequence это или literal
| @@ -439,6 +439,18 @@ bool FillColumnTableSchema(NKikimrSchemeOp::TColumnTableSchema& schema, const T& | |||
| auto columnIt = metadata.Columns.find(name); | |||
| Y_ENSURE(columnIt != metadata.Columns.end()); | |||
|
|
|||
| if (columnIt->second.IsDefaultFromSequence()) { | |||
| code = Ydb::StatusIds::BAD_REQUEST; | |||
| error = TStringBuilder() << "Default values are not supported in column tables"; | |||
There was a problem hiding this comment.
похоже, перепутаны местами ошибки здесь и ниже
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Первым шагом запрещаем использование default колонок в колоночных таблицах, в этом ревью запрет при создании колоночных таблиц
Changelog category
Description for reviewers
...