Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed return code of benchmark command for the case when query results differ from canonical ones #16192

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

iddqdex
Copy link
Collaborator

@iddqdex iddqdex commented Mar 25, 2025

@iddqdex iddqdex requested a review from a team as a code owner March 25, 2025 04:20
Copy link

🟢 2025-03-25 04:21:51 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 25, 2025

2025-03-25 04:24:10 UTC Pre-commit check linux-x86_64-release-asan for 27ea9e1 has started.
2025-03-25 04:24:24 UTC Artifacts will be uploaded here
2025-03-25 04:26:37 UTC ya make is running...
🟡 2025-03-25 04:47:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
664 642 0 4 10 8

2025-03-25 04:48:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-25 04:59:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 (only retried tests) 10 0 4 2 8

2025-03-25 04:59:37 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-25 05:10:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17 (only retried tests) 6 0 4 1 6

🟢 2025-03-25 05:10:58 UTC Build successful.
🟡 2025-03-25 05:11:14 UTC ydbd size 3.8 GiB changed* by +903.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b10a177 merge: 27ea9e1 diff diff %
ydbd size 4 082 318 976 Bytes 4 083 243 776 Bytes +903.1 KiB +0.023%
ydbd stripped size 1 410 564 936 Bytes 1 410 848 648 Bytes +277.1 KiB +0.020%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 25, 2025

2025-03-25 04:24:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 27ea9e1 has started.
2025-03-25 04:24:36 UTC Artifacts will be uploaded here
2025-03-25 04:26:55 UTC ya make is running...
🟢 2025-03-25 04:49:16 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1095 1080 0 0 8 7

🟢 2025-03-25 04:49:29 UTC Build successful.
🟡 2025-03-25 04:49:38 UTC ydbd size 2.2 GiB changed* by +368.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b10a177 merge: 27ea9e1 diff diff %
ydbd size 2 320 704 568 Bytes 2 321 081 888 Bytes +368.5 KiB +0.016%
ydbd stripped size 485 191 488 Bytes 485 260 992 Bytes +67.9 KiB +0.014%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@iddqdex iddqdex enabled auto-merge (squash) March 25, 2025 06:09
@iddqdex iddqdex merged commit 70be00c into ydb-platform:main Mar 25, 2025
15 checks passed
@iddqdex iddqdex deleted the diff-retcode branch March 25, 2025 08:04
iddqdex added a commit to iddqdex/ydb that referenced this pull request Mar 25, 2025
iddqdex added a commit to iddqdex/ydb that referenced this pull request Mar 25, 2025
iddqdex added a commit that referenced this pull request Mar 25, 2025
iddqdex added a commit that referenced this pull request Mar 25, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants