Support of different ydb flavours in tests #16213
Conversation
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for running tests against different ydb flavours by introducing a new fixture and updating test configurations accordingly.
- Introduces a fixture that extracts binary paths for different ydb flavours from environment variables.
- Updates the test configurator and pytest plugins to use the new fixture.
- Provides an example of how to parameterize tests with multiple ydb flavours.
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ydb/tests/library/flavours/init.py | Adds the flavour fixture to extract and map environment variables to binary paths. |
| ydb/tests/functional/tenants/test_users_groups_with_acl.py | Updates the configurator fixture to accept a binary path based on the new flavour fixture. |
| ydb/tests/functional/tenants/conftest.py | Includes the new flavour plugin in the pytest configuration. |
Files not reviewed (4)
- ydb/tests/functional/tenants/ya.make: Language not supported
- ydb/tests/library/flavours/flavours_deps.inc: Language not supported
- ydb/tests/library/flavours/ya.make: Language not supported
- ydb/tests/library/ya.make: Language not supported
Comments suppressed due to low confidence (2)
ydb/tests/library/flavours/init.py:16
- [nitpick] Consider enhancing this error message to include the expected environment variable prefix or list any discovered keys (if any) to aid debugging when the fixture is misconfigured.
raise RuntimeError("Flavours not found. Did you forget to include 'tests/library/flavours/flavours_deps.inc' in ya.make?")
ydb/tests/functional/tenants/test_users_groups_with_acl.py:22
- Ensure that tests are updated or added to cover scenarios with multiple ydb flavours, and include documentation for the new 'ydb_flavour_path' parameter in the fixture.
def ydb_configurator(ydb_cluster_configuration, domain_login_only, ydb_flavour_path):
Фикстура, которая позволяет параметризовывать тесты с разными версиями ydb (в том числе внутренними)
+ пример использования
#16120