Skip to content

Understandable transfer errors #16214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 26, 2025
Merged

Understandable transfer errors #16214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f82accd
wrong table type
nshestakov Mar 25, 2025
9610152
more tests
nshestakov Mar 25, 2025
6bd11fd
more test
nshestakov Mar 25, 2025
d370642
Update ydb/core/tx/replication/service/transfer_writer.cpp
nshestakov Mar 26, 2025
57fbeb7
fix
nshestakov Mar 26, 2025
7b0df06
fix
nshestakov Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ydb/core/tx/replication/controller/dst_creator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,12 +528,25 @@ class TDstCreator: public TActorBootstrapped<TDstCreator> {

STATEFN(StateSubscribeDstPath) {
switch (ev->GetTypeRewrite()) {
hFunc(TSchemeBoardEvents::TEvNotifyDelete, Handle);
hFunc(TSchemeBoardEvents::TEvNotifyUpdate, Handle);
default:
return StateBase(ev);
}
}

void Handle(TSchemeBoardEvents::TEvNotifyDelete::TPtr& ev) {
LOG_T("Handle " << ev->Get()->ToString());

switch (Kind) {
case TReplication::ETargetKind::Table:
case TReplication::ETargetKind::IndexTable:
return;
case TReplication::ETargetKind::Transfer:
return Error(NKikimrScheme::EStatus::StatusPathDoesNotExist, TStringBuilder() << "The target table `" << DstPath << "` does not exist");
}
}

void Handle(TSchemeBoardEvents::TEvNotifyUpdate::TPtr& ev) {
LOG_T("Handle " << ev->Get()->ToString());

Expand Down
8 changes: 5 additions & 3 deletions ydb/core/tx/replication/service/transfer_writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,13 +498,15 @@ class TTransferWriter
return;
}

// TODO support row tables
if (entry.Status == TNavigate::EStatus::PathNotTable || entry.Kind != TNavigate::KindColumnTable) {
return LogCritAndLeave("Only column tables are supported as transfer targets");
}

if (!CheckEntrySucceeded(entry)) {
return;
}

// TODO support row tables
CheckEntryKind(entry, TNavigate::KindColumnTable);

if (entry.Kind == TNavigate::KindColumnTable) {
TableState = std::make_unique<TColumnTableState>(SelfId(), result);
} else {
Expand Down
107 changes: 92 additions & 15 deletions ydb/tests/functional/transfer/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,28 +140,29 @@ struct MainTestCase {
{
}

void CreateTable(const TString& tableDDL) {
auto ddl = Sprintf(tableDDL.data(), TableName.data());
void ExecuteDDL(const TString& ddl) {
auto res = Session.ExecuteQuery(ddl, TTxControl::NoTx()).GetValueSync();
UNIT_ASSERT_C(res.IsSuccess(), res.GetIssues().ToString());
}

void CreateTable(const TString& tableDDL) {
ExecuteDDL(Sprintf(tableDDL.data(), TableName.data()));
}

void CreateTopic(size_t partitionCount = 10) {
auto res = Session.ExecuteQuery(Sprintf(R"(
ExecuteDDL(Sprintf(R"(
CREATE TOPIC `%s`
WITH (
min_active_partitions = %d
);
)", TopicName.data(), partitionCount), TTxControl::NoTx()).GetValueSync();
UNIT_ASSERT_C(res.IsSuccess(), res.GetIssues().ToString());
)", TopicName.data(), partitionCount));
}

void CreateConsumer(const TString& consumerName) {
auto res = Session.ExecuteQuery(Sprintf(R"(
ExecuteDDL(Sprintf(R"(
ALTER TOPIC `%s`
ADD CONSUMER `%s`;
)", TopicName.data(), consumerName.data()), TTxControl::NoTx()).GetValueSync();
UNIT_ASSERT_C(res.IsSuccess(), res.GetIssues().ToString());
)", TopicName.data(), consumerName.data()));
}

struct CreateTransferSettings {
Expand Down Expand Up @@ -200,7 +201,7 @@ struct MainTestCase {
sb << ", BATCH_SIZE_BYTES = " << *settings.BatchSizeBytes << Endl;
}

auto res = Session.ExecuteQuery(Sprintf(R"(
auto ddl = Sprintf(R"(
%s;

CREATE TRANSFER `%s`
Expand All @@ -209,9 +210,9 @@ struct MainTestCase {
CONNECTION_STRING = 'grpc://%s'
%s
);
)", lambda.data(), TransferName.data(), TopicName.data(), TableName.data(), ConnectionString.data(), sb.data()),
TTxControl::NoTx()).GetValueSync();
UNIT_ASSERT_C(res.IsSuccess(), res.GetIssues().ToString());
)", lambda.data(), TransferName.data(), TopicName.data(), TableName.data(), ConnectionString.data(), sb.data());

ExecuteDDL(ddl);
}

struct AlterTransferSettings {
Expand Down Expand Up @@ -360,7 +361,8 @@ struct MainTestCase {
for (size_t i = 20; i--;) {
auto result = DescribeTransfer().GetReplicationDescription();
if (TReplicationDescription::EState::Error == result.GetState()) {
Cerr << ">>>>> " << result.GetErrorState().GetIssues().ToOneLineString() << Endl << Flush;
Cerr << ">>>>> ACTUAL: " << result.GetErrorState().GetIssues().ToOneLineString() << Endl << Flush;
Cerr << ">>>>> EXPECTED: " << expectedMessage << Endl << Flush;
UNIT_ASSERT(result.GetErrorState().GetIssues().ToOneLineString().contains(expectedMessage));
break;
}
Expand Down Expand Up @@ -1242,7 +1244,34 @@ Y_UNIT_TEST_SUITE(Transfer)
}});
}

Y_UNIT_TEST(CreateTransferTopicNotExists)
Y_UNIT_TEST(CreateTransferSourceNotExists)
{
MainTestCase testCase;
testCase.CreateTable(R"(
CREATE TABLE `%s` (
Key Uint64 NOT NULL,
Message Utf8 NOT NULL,
PRIMARY KEY (Key)
) WITH (
STORE = COLUMN
);
)");

testCase.CreateTransfer(R"(
$l = ($x) -> {
return [
<|
Key:CAST($x._offset AS Uint64),
Message:CAST($x._data AS Utf8)
|>
];
};
)");

testCase.CheckTransferStateError("Discovery error: local/Topic_");
}

Y_UNIT_TEST(CreateTransferSourceIsNotTopic)
{
MainTestCase testCase;
testCase.CreateTable(R"(
Expand All @@ -1255,6 +1284,13 @@ Y_UNIT_TEST_SUITE(Transfer)
);
)");

testCase.ExecuteDDL(Sprintf(R"(
CREATE TABLE `%s` (
Key Uint64 NOT NULL,
PRIMARY KEY (Key)
);
)", testCase.TopicName.data()));

testCase.CreateTransfer(R"(
$l = ($x) -> {
return [
Expand Down Expand Up @@ -1292,7 +1328,48 @@ Y_UNIT_TEST_SUITE(Transfer)
};
)");

testCase.CheckTransferStateError("Unexpected entry kind at 'writer'");
testCase.CheckTransferStateError("Only column tables are supported as transfer targets");
}

Y_UNIT_TEST(CreateTransferTargetIsNotTable)
{
MainTestCase testCase;
testCase.CreateTable(R"(
CREATE TOPIC `%s`;
)");
testCase.CreateTopic();

testCase.CreateTransfer(R"(
$l = ($x) -> {
return [
<|
Key:CAST($x._offset AS Uint64),
Message:CAST($x._data AS Utf8)
|>
];
};
)");

testCase.CheckTransferStateError("Only column tables are supported as transfer targets");
}

Y_UNIT_TEST(CreateTransferTargetNotExists)
{
MainTestCase testCase;
testCase.CreateTopic();

testCase.CreateTransfer(R"(
$l = ($x) -> {
return [
<|
Key:CAST($x._offset AS Uint64),
Message:CAST($x._data AS Utf8)
|>
];
};
)");

testCase.CheckTransferStateError(TStringBuilder() << "The target table `/local/" << testCase.TableName << "` does not exist");
}
}

Loading