Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9056 Refactor YDB CLI by extracting highlight and complete modules #16286

Merged
merged 6 commits into from
Mar 27, 2025

Conversation

vityaman
Copy link
Contributor

@vityaman vityaman commented Mar 26, 2025

Changelog entry

Extract highlight and complete modules in YDB CLI.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

  • Moved completer and highlighter code to separate modules
  • Add T, I type prefixes
  • Add interfaces with factory methods
  • Fix a bug with a contextLen

@vityaman vityaman marked this pull request as ready for review March 26, 2025 13:55
@vityaman vityaman requested a review from a team as a code owner March 26, 2025 13:55
Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@vityaman
Copy link
Contributor Author

@pnv1, what do you think about it?

Copy link

github-actions bot commented Mar 26, 2025

🟢 2025-03-26 13:58:57 UTC The validation of the Pull Request description is successful.

pnv1
pnv1 previously approved these changes Mar 27, 2025
@pnv1 pnv1 added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Mar 27, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Mar 27, 2025
Copy link

github-actions bot commented Mar 27, 2025

2025-03-27 09:10:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2641270 has started.
2025-03-27 09:11:12 UTC Artifacts will be uploaded here
🔴 2025-03-27 09:12:55 UTC Graph compare failed, see the logs.

Copy link

github-actions bot commented Mar 27, 2025

2025-03-27 09:11:04 UTC Pre-commit check linux-x86_64-release-asan for 2641270 has started.
2025-03-27 09:11:20 UTC Artifacts will be uploaded here
🔴 2025-03-27 09:13:02 UTC Graph compare failed, see the logs.

@pnv1 pnv1 added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Mar 27, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Mar 27, 2025
Copy link

github-actions bot commented Mar 27, 2025

2025-03-27 11:54:33 UTC Pre-commit check linux-x86_64-release-asan for 8711dec has started.
2025-03-27 11:54:37 UTC Artifacts will be uploaded here
2025-03-27 11:56:58 UTC ya make is running...
🔴 2025-03-27 11:57:13 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Mar 27, 2025

2025-03-27 11:55:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8711dec has started.
2025-03-27 11:56:12 UTC Artifacts will be uploaded here
2025-03-27 11:58:33 UTC ya make is running...
🔴 2025-03-27 11:58:47 UTC Build failed, see the logs. Also see fail summary

@pnv1 pnv1 added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Mar 27, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Mar 27, 2025
Copy link

github-actions bot commented Mar 27, 2025

2025-03-27 13:47:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 40fc570 has started.
2025-03-27 13:47:19 UTC Artifacts will be uploaded here
2025-03-27 13:49:35 UTC ya make is running...
🟡 2025-03-27 14:29:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1085 1046 0 6 27 6

2025-03-27 14:29:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-27 14:39:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40 (only retried tests) 37 0 0 0 3

🟢 2025-03-27 14:39:40 UTC Build successful.
🟢 2025-03-27 14:39:52 UTC ydbd size 2.2 GiB changed* by +85.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ea4ffc9 merge: 40fc570 diff diff %
ydbd size 2 343 530 696 Bytes 2 343 618 384 Bytes +85.6 KiB +0.004%
ydbd stripped size 490 087 648 Bytes 490 103 072 Bytes +15.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 27, 2025

2025-03-27 13:47:10 UTC Pre-commit check linux-x86_64-release-asan for 40fc570 has started.
2025-03-27 13:47:25 UTC Artifacts will be uploaded here
2025-03-27 13:49:46 UTC ya make is running...
🟡 2025-03-27 14:18:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
654 630 0 5 8 11

2025-03-27 14:18:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-27 14:36:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26 (only retried tests) 6 0 5 8 7

2025-03-27 14:37:07 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-27 14:56:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
23 (only retried tests) 5 0 5 6 7

🟢 2025-03-27 14:56:47 UTC Build successful.
🟡 2025-03-27 14:57:05 UTC ydbd size 3.8 GiB changed* by +140.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c0dc323 merge: 40fc570 diff diff %
ydbd size 4 112 325 824 Bytes 4 112 469 304 Bytes +140.1 KiB +0.003%
ydbd stripped size 1 421 088 872 Bytes 1 421 134 888 Bytes +44.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pnv1 pnv1 merged commit 6550d3e into ydb-platform:main Mar 27, 2025
15 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants