Skip to content

YQL-19520: Enable i128 <-> UnboxedValuePod proxy for codegen #16306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

YQL-19520: Enable i128 <-> UnboxedValuePod proxy for codegen #16306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/core/kqp/runtime/kqp_compute.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class TKqpEnsureWrapper : public TMutableCodegeneratorNode<TKqpEnsureWrapper> {
BranchInst::Create(good, kill, pass, block);

block = kill;
const auto doFunc = ConstantInt::get(Type::getInt64Ty(context), GetMethodPtr(&TKqpEnsureWrapper::Throw));
const auto doFunc = ConstantInt::get(Type::getInt64Ty(context), GetMethodPtr<&TKqpEnsureWrapper::Throw>());
const auto doFuncArg = ConstantInt::get(Type::getInt64Ty(context), (ui64)this);
const auto doFuncType = FunctionType::get(Type::getVoidTy(context), { Type::getInt64Ty(context), ctx.Ctx->getType() }, false);
const auto doFuncPtr = CastInst::Create(Instruction::IntToPtr, doFunc, PointerType::getUnqual(doFuncType), "thrower", block);
Expand Down
4 changes: 2 additions & 2 deletions ydb/core/kqp/runtime/kqp_read_table.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ class TKqpScanWideReadTableWrapperBase : public TStatelessWideFlowCodegeneratorN
new StoreInst(init, fields, &ctx.Func->getEntryBlock().back());

const auto ptrType = PointerType::getUnqual(StructType::get(context));
const auto func = ConstantInt::get(Type::getInt64Ty(context), GetMethodPtr(&TKqpScanWideReadTableWrapperBase::DoCalculate));
const auto func = ConstantInt::get(Type::getInt64Ty(context), GetMethodPtr<&TKqpScanWideReadTableWrapperBase::DoCalculate>());
const auto self = CastInst::Create(Instruction::IntToPtr, ConstantInt::get(Type::getInt64Ty(context), uintptr_t(this)), ptrType, "self", block);
const auto funcType = FunctionType::get(Type::getInt32Ty(context), { self->getType(), ctx.Ctx->getType(), fields->getType() }, false);
const auto funcPtr = CastInst::Create(Instruction::IntToPtr, func, PointerType::getUnqual(funcType), "fetch_func", block);
Expand Down Expand Up @@ -410,7 +410,7 @@ class TKqpScanBlockReadTableWrapperBase : public TStatelessWideFlowCodegenerator
new StoreInst(init, fields, &ctx.Func->getEntryBlock().back());

const auto ptrType = PointerType::getUnqual(StructType::get(context));
const auto func = ConstantInt::get(Type::getInt64Ty(context), GetMethodPtr(&TKqpScanBlockReadTableWrapperBase::DoCalculate));
const auto func = ConstantInt::get(Type::getInt64Ty(context), GetMethodPtr<&TKqpScanBlockReadTableWrapperBase::DoCalculate>());
const auto self = CastInst::Create(Instruction::IntToPtr, ConstantInt::get(Type::getInt64Ty(context), uintptr_t(this)), ptrType, "self", block);
const auto funcType = FunctionType::get(Type::getInt32Ty(context), { self->getType(), ctx.Ctx->getType(), fields->getType() }, false);
const auto funcPtr = CastInst::Create(Instruction::IntToPtr, func, PointerType::getUnqual(funcType), "fetch_func", block);
Expand Down
Loading