Skip to content

Don't wait for TEvReadSetAck from non-existent tablets (#17913) #18005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented May 5, 2025

Changelog entry

Moved changes from #17913

Issue #17915

The PQ tablet forgets about the transaction only after it receives a TEvReadSetAck from all participants. Another shard may be deleted before the PQ completes the transaction (for example, due to a split table). As a result, transactions are executed, but remain in the WAIT_RS_ACKS state.

If the PQ tablet sends a TEvReadSet to a tablet that has already been deleted, it receives a TEvClientConnected with the Dead flag in response. In this case, we consider that we have received a TEvReadSetAck.

Changelog category

  • Bugfix

Description for reviewers

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner May 5, 2025 10:14
@Alek5andr-Kotov Alek5andr-Kotov enabled auto-merge May 5, 2025 10:19
Copy link

github-actions bot commented May 5, 2025

2025-05-05 10:36:44 UTC Pre-commit check for 6e9a3e0 has started.
2025-05-05 10:39:44 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-05-05 11:18:38 UTC Build successful.
2025-05-05 11:18:52 UTC Tests are running...
🔴 2025-05-05 12:55:50 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14818 13458 0 22 1303 35

🟢 2025-05-05 12:56:41 UTC ydbd size 8.3 GiB changed* by +66.7 KiB, which is < 100.0 KiB vs stable-24-4-4-hotfix: OK

ydbd size dash stable-24-4-4-hotfix: eb22692 merge: 6e9a3e0 diff diff %
ydbd size 8 899 188 200 Bytes 8 899 256 528 Bytes +66.7 KiB +0.001%
ydbd stripped size 485 048 456 Bytes 485 051 080 Bytes +2.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 5, 2025

2025-05-05 10:41:04 UTC Pre-commit check for 6e9a3e0 has started.
2025-05-05 10:44:04 UTC Build linux-x86_64-release-asan is running...
🟢 2025-05-05 11:07:03 UTC Build successful.
2025-05-05 11:07:20 UTC Tests are running...
🔴 2025-05-05 13:22:43 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10388 10279 0 42 26 41

🟢 2025-05-05 13:23:26 UTC ydbd size 5.6 GiB changed* by +23.2 KiB, which is < 100.0 KiB vs stable-24-4-4-hotfix: OK

ydbd size dash stable-24-4-4-hotfix: eb22692 merge: 6e9a3e0 diff diff %
ydbd size 6 028 322 384 Bytes 6 028 346 104 Bytes +23.2 KiB +0.000%
ydbd stripped size 1 508 560 768 Bytes 1 508 565 824 Bytes +4.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit e26ec2c into ydb-platform:stable-24-4-4-hotfix May 5, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants