Skip to content

Don't wait for TEvReadSetAck from non-existent tablets (#17913) #18007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented May 5, 2025

Changelog entry

Moved changes from #17913

Issue #17915

The PQ tablet forgets about the transaction only after it receives a TEvReadSetAck from all participants. Another shard may be deleted before the PQ completes the transaction (for example, due to a split table). As a result, transactions are executed, but remain in the WAIT_RS_ACKS state.

If the PQ tablet sends a TEvReadSet to a tablet that has already been deleted, it receives a TEvClientConnected with the Dead flag in response. In this case, we consider that we have received a TEvReadSetAck.

Changelog category

  • Bugfix

Description for reviewers

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner May 5, 2025 10:15
Copy link

github-actions bot commented May 5, 2025

2025-05-05 10:18:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 368bb1a has started.
2025-05-05 10:19:00 UTC Artifacts will be uploaded here
2025-05-05 10:22:15 UTC ya make is running...
🟡 2025-05-05 11:31:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18931 17649 0 5 1212 65

2025-05-05 11:33:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-05 11:55:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
138 (only retried tests) 75 0 0 1 62

🟢 2025-05-05 11:55:09 UTC Build successful.
🟢 2025-05-05 11:55:34 UTC ydbd size 2.1 GiB changed* by +9.0 KiB, which is < 100.0 KiB vs stable-25-1-1: OK

ydbd size dash stable-25-1-1: 54dc8dc merge: 368bb1a diff diff %
ydbd size 2 243 535 408 Bytes 2 243 544 624 Bytes +9.0 KiB +0.000%
ydbd stripped size 475 079 224 Bytes 475 081 848 Bytes +2.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov enabled auto-merge May 5, 2025 10:19
Copy link

github-actions bot commented May 5, 2025

2025-05-05 11:04:50 UTC Pre-commit check linux-x86_64-release-asan for 368bb1a has started.
2025-05-05 11:04:54 UTC Artifacts will be uploaded here
2025-05-05 11:07:47 UTC ya make is running...
🟡 2025-05-05 12:17:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11836 11742 0 33 25 36

2025-05-05 12:18:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-05 12:39:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
134 (only retried tests) 100 0 1 1 32

2025-05-05 12:39:41 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-05 13:00:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 29 0 1 0 31

🟢 2025-05-05 13:00:12 UTC Build successful.
🟢 2025-05-05 13:00:40 UTC ydbd size 3.6 GiB changed* by +10.6 KiB, which is < 100.0 KiB vs stable-25-1-1: OK

ydbd size dash stable-25-1-1: 54dc8dc merge: 368bb1a diff diff %
ydbd size 3 902 609 408 Bytes 3 902 620 280 Bytes +10.6 KiB +0.000%
ydbd stripped size 1 365 658 736 Bytes 1 365 662 704 Bytes +3.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit 7e9b044 into ydb-platform:stable-25-1-1 May 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants