Skip to content

Fix BSC VDisk metrics unknown fields exchange #18012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented May 5, 2025

Changelog entry

Fix BSC VDisk metrics unknown fields exchange

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This fixes accidental leaking of VDiskMetrics on previous versions of BSC receiving modern VDisk metrics due to presence of unknown fields.

Copy link

github-actions bot commented May 5, 2025

🟢 2025-05-05 14:31:39 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented May 5, 2025

2025-05-05 11:12:49 UTC Pre-commit check linux-x86_64-release-asan for 6710092 has started.
2025-05-05 11:13:00 UTC Artifacts will be uploaded here
2025-05-05 11:16:08 UTC ya make is running...
🔴 2025-05-05 11:37:31 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented May 5, 2025

2025-05-05 11:42:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6710092 has started.
2025-05-05 11:42:56 UTC Artifacts will be uploaded here
2025-05-05 11:46:05 UTC ya make is running...
🔴 2025-05-05 11:57:20 UTC Build failed, see the logs. Also see fail summary

@alexvru alexvru force-pushed the bsdc/fix-metrics-unknown-fields-exchange branch from 219a4db to 073ede0 Compare May 5, 2025 12:15
Copy link

github-actions bot commented May 5, 2025

2025-05-05 12:29:11 UTC Pre-commit check linux-x86_64-release-asan for cd43b19 has started.
2025-05-05 12:29:21 UTC Artifacts will be uploaded here
2025-05-05 12:32:27 UTC ya make is running...
🟡 2025-05-05 14:32:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14878 14697 0 112 41 28

2025-05-05 14:33:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-05 15:00:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1011 (only retried tests) 894 0 55 36 26

2025-05-05 15:00:32 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-05 15:25:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
840 (only retried tests) 737 0 46 31 26

🟢 2025-05-05 15:25:54 UTC Build successful.
🔴 2025-05-05 15:26:25 UTC ydbd size 3.8 GiB changed* by +4.6 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 71218f4 merge: cd43b19 diff diff %
ydbd size 4 121 683 000 Bytes 4 126 496 960 Bytes +4.6 MiB +0.117%
ydbd stripped size 1 429 119 256 Bytes 1 433 271 064 Bytes +4.0 MiB +0.291%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 5, 2025

2025-05-05 12:43:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for cd43b19 has started.
2025-05-05 12:44:16 UTC Artifacts will be uploaded here
2025-05-05 12:48:10 UTC ya make is running...
🟡 2025-05-05 14:40:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29702 27015 0 4 2635 48

2025-05-05 14:42:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-05 15:08:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
729 (only retried tests) 693 0 1 0 35

2025-05-05 15:08:46 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-05 15:33:32 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
118 (only retried tests) 85 0 0 0 33

🟢 2025-05-05 15:33:38 UTC Build successful.
🟢 2025-05-05 15:34:01 UTC ydbd size 2.2 GiB changed* by +37.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a8596d8 merge: cd43b19 diff diff %
ydbd size 2 343 324 672 Bytes 2 343 363 208 Bytes +37.6 KiB +0.002%
ydbd stripped size 493 063 040 Bytes 493 066 496 Bytes +3.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant