Skip to content

Correct SchemeRoot determination based on bootstrap config #18054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented May 6, 2025

Changelog entry

Correct SchemeRoot determination based on bootstrap config

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

SchemeRoot value is now derived correctly when no domains_config section is present. Value is taken from bootstrapper config, if provided, or a default value taken.

Copy link

github-actions bot commented May 6, 2025

🟢 2025-05-06 08:56:46 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented May 6, 2025

2025-05-06 08:57:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4953b9f has started.
2025-05-06 08:57:20 UTC Artifacts will be uploaded here
2025-05-06 09:00:13 UTC ya make is running...
🟡 2025-05-06 10:13:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20964 19589 0 7 1327 41

2025-05-06 10:14:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-06 10:38:26 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
267 (only retried tests) 234 0 0 0 33

🟢 2025-05-06 10:38:36 UTC Build successful.
🟢 2025-05-06 10:38:56 UTC ydbd size 2.2 GiB changed* by +5.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0f55ef2 merge: 4953b9f diff diff %
ydbd size 2 343 599 608 Bytes 2 343 605 400 Bytes +5.7 KiB +0.000%
ydbd stripped size 493 088 992 Bytes 493 093 792 Bytes +4.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@mregrock mregrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented May 6, 2025

2025-05-06 09:00:55 UTC Pre-commit check linux-x86_64-release-asan for 4953b9f has started.
2025-05-06 09:00:59 UTC Artifacts will be uploaded here
2025-05-06 09:03:51 UTC ya make is running...
🟡 2025-05-06 10:31:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13169 12962 0 141 39 27

2025-05-06 10:32:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-06 11:02:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1042 (only retried tests) 940 0 51 25 26

2025-05-06 11:03:11 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-06 11:29:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
729 (only retried tests) 619 0 49 34 27

🟢 2025-05-06 11:29:43 UTC Build successful.
🟢 2025-05-06 11:30:17 UTC ydbd size 3.8 GiB changed* by +2.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0f55ef2 merge: 4953b9f diff diff %
ydbd size 4 126 869 592 Bytes 4 126 872 232 Bytes +2.6 KiB +0.000%
ydbd stripped size 1 433 326 552 Bytes 1 433 327 768 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А тесты будут?

Copy link
Member

@CyberROFL CyberROFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mregrock написал, что тест есть, но еще не закоммичен.

@mregrock
Copy link
Collaborator

mregrock commented May 6, 2025

Тест
#17993
Если поставить другой schemeshard id то тест падает по верифайке/таймауту

@alexvru alexvru merged commit b2d8cc5 into ydb-platform:main May 7, 2025
15 checks passed
@alexvru alexvru deleted the config/correct-scheme-root-determination branch May 7, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants