[Backport stable-26-3] PR #49216: Reduce test size under sanitizer - #49238
Conversation
|
⚪
🟢 |
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢 |
AI Review SummaryVerdict: No critical issues found Critical issuesNo critical issues found. Other findings
DetailsThis is a clean backport cherry-pick of PR #49216. The diff is identical to the original (only line numbers differ due to the stable-26-3 branch). The change is correct and follows established patterns in the codebase:
No correctness, crash, data-loss, security, concurrency, or performance issues found. This review was generated automatically. Critical issues require attention; other findings are advisory. |
| // full column count (the test validates wide-schema behavior) but reduce | ||
| // the row count so the BulkUpsert fits within the timeout. See | ||
| // NSan::PlainOrUnderSanitizer. | ||
| const ui64 numColumns = 9900; |
There was a problem hiding this comment.
Severity: Nit
Confidence: Low
numColumns, alterColumnsFrom, and alterColumnsTo are constant-valued -- they don't use PlainOrUnderSanitizer and always evaluate to 9900, 9900, and 9999 respectively. They serve purely as named constants replacing magic numbers.
This is a nice readability improvement (makes the relationship between the values explicit and easier to change in the future), but it goes slightly beyond the minimal sanitizer fix. No action needed -- just noting for completeness.
Changelog entry
Reduce test size under sanitizer
Description for reviewers
Original PR(s)
Metadata
Git Cherry-Pick Log
PR was created by cherry-pick workflow run