Skip to content

Rework Entity parsing implementation, foundation for comment improvements #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rework Entity parsing implementation, foundation for comment improvements #1580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dde5b8f
Add test to illustrate current comments behavior
danbroooks Mar 29, 2025
54be9d6
Refactor entity block parsing
danbroooks Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
393 changes: 217 additions & 176 deletions persistent/Database/Persist/Quasi/Internal.hs
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion persistent/persistent.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,12 @@ test-suite test
Database.Persist.ClassSpec
Database.Persist.PersistValueSpec
Database.Persist.QuasiSpec
Database.Persist.TH.CommentSpec
Database.Persist.TH.CommentsSpec
Database.Persist.TH.CompositeKeyStyleSpec
Database.Persist.TH.DiscoverEntitiesSpec
Database.Persist.TH.EmbedSpec
Database.Persist.TH.EntityHaddockSpec
Database.Persist.TH.EntityHaddockSpec.CommentModel
Database.Persist.TH.ForeignRefSpec
Database.Persist.TH.ImplicitIdColSpec
Database.Persist.TH.JsonEncodingSpec
Expand Down
Loading
Loading