Skip to content

Mina verifiers #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 330 commits into from
Closed

Mina verifiers #506

wants to merge 330 commits into from

Conversation

@gabrielbosio
Copy link
Collaborator

@gabrielbosio gabrielbosio commented Jun 26, 2024 •
edited
Loading

Mina verifiers

Implements Mina State verifier and Mina Account inclusion verifier.

Components

  • Mina State verifier: Runs a Pickles verification of a Mina State proof and checks that the Mina State is from a chain that was agreed by the network as safe. This proof can be fetched from Mina Devnet (link to Docker image) or from Mina Mainnet (link to Docker image).
  • Mina Account Inclusion verifier: Runs a Merkle proof verification to check that a Mina account is present in the Mina Ledger.

Details

  • Changes Go workflow runner to use Aligned runner because of memory limitations when adding Mina jobs.
  • Adds Make commands to send Mina test proofs and build and test Mina FFIs.
    • Documents in the guide how to send Mina test proofs.
  • Logs gas used in Aggregator and Mina verifiers.
  • Patches Arkworks in Batcher so that it uses OpenMina's fork.
  • Implements Mina State verifier and Mina Account inclusion verifier.
  • Adds Mina and MinaAccount to ProvingSystemId enum.

gabrielbosio and others added 30 commits July 23, 2024 12:14
@gabrielbosio
Merge pull request #11 from lambdaclass/new_public_inputs
65ace03 
Add new serialized protocol state as public inputs
@gabrielbosio
Merge branch 'mina' into consensus
c4afc9e
@xqft
Fix Makefile and pre-verif checks
d359a25
@xqft
Fix mina operator bindings
c18e513
@gabrielbosio
Merge pull request #14 from lambdaclass/mina_flow
1dcd2d9 
Fix Mina operator flow for proof of new node
@gabrielbosio
Use OpenMina in consensus check
619d629
@gabrielbosio
Merge branch 'mina' into consensus
be87664
@gabrielbosio
Prepare to receive more public inputs
f28978e
@gabrielbosio
Invert chain selection arguments order
c34f794 
To maintain consistency.
@gabrielbosio
Update test files
4b4a89a
@gabrielbosio
Add test files for consensus check
a6a464b
@xqft
Merge remote-tracking branch 'upstream/main' into mina
d9d0d57
@gabrielbosio
Add state size in pub input deserialization
43fb3c3
@gabrielbosio
Revert "Add state size in pub input deserialization"
4c49ddf 
This reverts commit 43fb3c3.
@gabrielbosio
Use Mainnet and adapt to new state size
524e0fa
@gabrielbosio
Update test files and remove bad consensus test
fed2ad4
@gabrielbosio
Add state size check in batcher
feeb6aa
@xqft
Merge pull request #7 from lambdaclass/consensus
cdb2438 
Consensus check
@gabrielbosio
Read state size in batcher
a00d8c6
@gabrielbosio
Make operator read state size in pub input
703fe27
@gabrielbosio
Update Mina test make cmds
be1f6b9
@gabrielbosio
Update operator tests
49e60b1
@gabrielbosio
Merge pull request #16 from lambdaclass/state_size_in_pub_input
e0e42d2 
State size in protocol state public input
@xqft
Change order of pub inputs, simplify fns and names
c99e66c
@xqft
Update test files
5c11fa3
@xqft
Update batcher pre-verification
1e86a2a
@gabrielbosio
Change Holesky Aligned contract address
3ca8bc8
@gabrielbosio
Log batcher gas cost
b602274
@gabrielbosio
Log aggregator gas cost
8873369
@gabrielbosio
Merge branch 'main' into mina
e4bc95d
gabrielbosio and others added 27 commits March 7, 2025 12:30
@gabrielbosio
Add Mina and Mina Account steps to send all cmd
614012d
@gabrielbosio
Merge pull request #51 from lambdaclass/add_mina_proofs_to_send_all_cmd
59b1fe0 
Include Mina and Mina account verification in the integration test
@gabrielbosio
Handle Mina pub input errors
2ed9faa
@gabrielbosio
Improve verification key error handling
0cf098b
@gabrielbosio
Replace eprintln calls with logger
5adec30
@gabrielbosio
Merge pull request #50 from lambdaclass/check_merkle_root_result
7e0b2ff 
Check result of computing Merkle Root of Mina Account
@gabrielbosio
Merge pull request #52 from lambdaclass/handle_verify_internal_errors
b8edf9e 
Handle Mina public input errors
@gabrielbosio
Merge pull request #53 from lambdaclass/improve_vk_error_handling
555e28c 
Improve verification key error handling
@gabrielbosio
Merge pull request #54 from lambdaclass/replace_eprintln_calls
cebeee7 
Replace `eprintln!` calls with Logger calls
@gabrielbosio
Use rev instead of branch for OM and Bridge deps
e881bc4
@gabrielbosio
Merge pull request #55 from lambdaclass/use_rev_instead_of_branch
220546a 
Use rev instead of branch for OpenMina and Bridge dependencies
@gabrielbosio
Improve Mina verification FFI
279aa75 
- Change proof and pub input types from array to C pointer
- Remove max size constants
- Now the batcher does not use FFI to verify Mina proofs
@gabrielbosio
Fix Mina FFI tests
4fe4a2f
@gabrielbosio
Fix Mina account FFI
c7eb450
@gabrielbosio
Merge pull request #56 from lambdaclass/improve_ffi_arg_types
c26ad54 
Improve Mina verification FFI
@gabrielbosio
Fix batcher clippy issues
ccbe588
@gabrielbosio
Remove pub input len log
836ce51
@gabrielbosio
Test null ptr cases in Mina verifier
27c2f85
@gabrielbosio
Add empty test case for Mina FFI
e973022
@gabrielbosio
Add Mainnet case for Mina FFI
260c051
@gabrielbosio
Add tests for Mina account FFI
761d383
@gabrielbosio
Fix tests
df5c035
@gabrielbosio
Merge pull request #57 from lambdaclass/add_tests
8755559 
Increase Mina and Mina Account FFI coverage
@gabrielbosio
Document Mina verifier
a82fd67
@gabrielbosio
Document Mina Account verifier
10fe27c
@gabrielbosio
Merge pull request #58 from lambdaclass/improve_mina_docs
83f0b1b 
Improve Mina verifier documentation
@gabrielbosio
Merge branch 'staging' into mina
10bd8c6
@MarcosNicolau MarcosNicolau mentioned this pull request Oct 31, 2025
Merged
14 tasks
@gabrielbosio
Copy link
Collaborator Author

gabrielbosio commented Nov 5, 2025

Closing in favor of #2163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gabrielbosio @Oppen @xqft @MauroToscano