ksearch: upgrade to Events API by Fondryext · Pull Request #508 · yext/search-ui-react

Fondryext · 2025-04-07T16:55:37Z

This PR upgrades our analytics calls to the next major version, also called the Events API. As part of this work, analytics calls have changed shape, and some deprecated properties have been dropped.
A variety of Typescript errors have also begun firing when running the test-site, so this PR additionally adds a variety
of mostly cosmetic changes, things like assigning types or exporting as type.
J=WAT-4651
TEST=auto,manual

Updated auto tests. Ran test site locally and saw events all the way to snowflake.

github-actions · 2025-04-07T16:59:14Z

Current unit coverage is 89.19831223628692%
Current visual coverage is 69.45975744211687%
Current combined coverage is 92.55890863993386%

coveralls · 2025-04-07T20:14:50Z

coverage: 85.288% (-0.5%) from 85.752%
when pulling 0f64d41 on dev/events-api
into 4ee1e8b on main.

Fondryext · 2025-07-03T16:59:07Z

+    searchTerm?: string;
+}
+
+//todo - how many of these do we want to delete?


I want to prune these down - open to what we use as our canonical list.

Is there a reason we want to prune these down? At the very least, I imagine we want things like map pin, auto complete selection, the paginates, chat impression, search clear, etc.

So as we discussed, let's pare this down based on user event types and then consider any remaining enum types more individually. If it's clearly search related or has been used before, include it. If it's clearly for another product, exclude it, etc. Use your discretion, but feel free to loop in Baigel / others if you want a 2nd opinion while I'm out.

vijay267 · 2025-08-21T20:20:52Z

+    searchTerm?: string;
+}
+
+//todo - how many of these do we want to delete?


Is there a reason we want to prune these down? At the very least, I imagine we want things like map pin, auto complete selection, the paginates, chat impression, search clear, etc.

vijay267

Generally looks good! Had some comments about specific details, but I like the wrapper, and overall the changes make sense.

vijay267 · 2025-08-21T20:38:57Z

+    searchTerm?: string;
+}
+
+//todo - how many of these do we want to delete?


So as we discussed, let's pare this down based on user event types and then consider any remaining enum types more individually. If it's clearly search related or has been used before, include it. If it's clearly for another product, exclude it, etc. Use your discretion, but feel free to loop in Baigel / others if you want a 2nd opinion while I'm out.

This PR upgrades our analytics calls to the next major version, also called the Events API. As part of this work, analytics calls have changed shape, and some deprecated properties have been dropped. J=WAT-4651 TEST=auto,manual Updated auto tests. Ran test site locally and saw events all the way to snowflake.

…y notices check

analytics import

…y notices check

vijay267

Looks good to me! Looks like some checks were failing though, so let's double check those.

k-gerner

Reviewing the typescript fixes only, since the previous changes were already approved by both me and Deepak

@chrissnyder2337

* Support trusted publishing with OIDC (#558) * Bump search-headless-react version (to be published as v1.10.0) (#561) which includes change that supports facetAllowlist query parameter for vertical searches * release: v1.10.0-beta.0 * release: v1.10.0 * drop node 16 from github workflows (#567) * drop node 16 from github workflows We are dropping node 16 support, and have removed it from the related slapshot reusable workflows already. This PR drops it from the github workflows for this repo J=none TEST=none * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * v1.10.1 (#569) * v1.10.1 (#565) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: upgrade playwright version to avoid vuln This PR ups the playwright version used to avoid a vuln J=VULN-40423 TEST=compile * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * remove version upgrade workflow * remove version change * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * release: v1.10.1 * Move map to search location when there are no results (v1.10.2) (#570) J=WAT-5112 TEST=manual --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.10.2 * Fix orphaned ARIA references when collapsible=false (#579) Fix originally made in #576 by @chrissnyder2337 When collapsible={false}, FilterGroup now renders a plain div instead of CollapsibleSection, preventing orphaned aria-labelledby references that point to non-existent toggle button IDs. This fix improves WCAG 2.1 accessibility compliance (1.3.1 Info and Relationships; 4.1.2 Name, Role, Value) by ensuring screen readers only encounter properly labeled regions. --------- Co-authored-by: Claude <noreply@anthropic.com> * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: Chris Snyder <chris@chrissnyder.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.10.3 * release: v1.10.3-beta.0 * release: v1.10.3 * chore: update search bar components to improve accessibility (v1.10.4) (#584) * update search bar components to improve accessibility * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * update tests * Update snapshots * Update snapshots * Update snapshots * add required aria attributes to pass WCAG * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * update storybook styling for dropdown items * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore: update generate license config (#586) * update generate license config * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * try using test branch of workflow * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * fix typo * Update snapshots * add generate_license_version param to yml * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * Update snapshots * Update snapshots * Update snapshots * update text in jsonlint-lines-primitives override * Update snapshots * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * remove extra dashed line * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * Update snapshots * point to v1 workflow branch after update in that repo * Update snapshots * Update snapshots * capitalization typo from prev PR * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.10.4 * feat: upgrade to React 19; add backwards compatibility test-site script (v1.11.0) (#589) * upgrade to React 19; add backwards compatibility test-site script * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * try updating run-tests.yml * codex: try fixing old react errors * update storybook command from p -> port * update types and fiddle with Mapbox pin code to pass storybook tests * wrap various tasts with act() to cut down on log warns * try to update storybook config to get tests to pass * Update snapshots * Update snapshots * Update snapshots * Update snapshots * rerun npm i in test site * slight code cleanup * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * nits * Update snapshots * Update snapshots * update kill command in visual coverage * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.11.0 * fix: handle mapbox padding race condition (v1.11.1) (#592) * add logic to only fit bounds when padding fits in canvas * release: v1.11.1 * fix: upgrade storybook version (#595) A vulnerability exists in storybook 8.5.0 that bundles the .env file in the static output during the storybook build. This vulnerability is fixed in version 8.6.15. J=VULN-40848 TEST=auto --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat: support autocomplete limits (v1.12.0) (#597) * support autocomplete limits * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.12.0 * hotfix: some symbol layers not showing up (v1.12.1) (#601) Layers that don't have name properties do not need to be localized (e.g. highway numbers). Localizing them was overriding their properties, which caused them to not show up on the map. J= WAT-5275 TEST=manual verified on test-site that road shields and route markers now show up, and place names are still localized as expected. * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * add parenthesis to make conditions clearer * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.12.1 * chore: reduce update snapshot commit hook flakiness (#600) * try awaiting to reduce update snapshot flakiness * additional update to static filters since that caused some snapshot failures too * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * ability to disable autocomplete in SearchBar (v1.12.2) (#605) J=WAT-5279 TEST=manual,auto tested on test-site added new test case to SearchBar.test.tsx and ran npm run test * release: v1.12.2 * ksearch: upgrade to Events API (#508) * ksearch: upgrade to Events API This PR upgrades our analytics calls to the next major version, also called the Events API. As part of this work, analytics calls have changed shape, and some deprecated properties have been dropped. J=WAT-4651 TEST=auto,manual Updated auto tests. Ran test site locally and saw events all the way to snowflake. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v2.0.0 * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check --------- Co-authored-by: anguyen-yext2 <143001514+anguyen-yext2@users.noreply.github.com> Co-authored-by: anguyen-yext2 <anguyen@yext.com> Co-authored-by: Fondryext <160865254+Fondryext@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Maxfield Kouzel <mkouzel@yext.com> Co-authored-by: Chris Snyder <chris@chrissnyder.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Kyle Gerner <49618240+k-gerner@users.noreply.github.com> Co-authored-by: Kyle Gerner <kgerner@yext.com> Co-authored-by: Jacob Fondriest <jfondriest@yext.com>

@chrissnyder2337

* Support trusted publishing with OIDC (#558) * Bump search-headless-react version (to be published as v1.10.0) (#561) which includes change that supports facetAllowlist query parameter for vertical searches * release: v1.10.0-beta.0 * release: v1.10.0 * drop node 16 from github workflows (#567) * drop node 16 from github workflows We are dropping node 16 support, and have removed it from the related slapshot reusable workflows already. This PR drops it from the github workflows for this repo J=none TEST=none * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * v1.10.1 (#569) * v1.10.1 (#565) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: upgrade playwright version to avoid vuln This PR ups the playwright version used to avoid a vuln J=VULN-40423 TEST=compile * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * remove version upgrade workflow * remove version change * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * release: v1.10.1 * Move map to search location when there are no results (v1.10.2) (#570) J=WAT-5112 TEST=manual --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.10.2 * Fix orphaned ARIA references when collapsible=false (#579) Fix originally made in #576 by @chrissnyder2337 When collapsible={false}, FilterGroup now renders a plain div instead of CollapsibleSection, preventing orphaned aria-labelledby references that point to non-existent toggle button IDs. This fix improves WCAG 2.1 accessibility compliance (1.3.1 Info and Relationships; 4.1.2 Name, Role, Value) by ensuring screen readers only encounter properly labeled regions. --------- Co-authored-by: Claude <noreply@anthropic.com> * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: Chris Snyder <chris@chrissnyder.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.10.3 * release: v1.10.3-beta.0 * release: v1.10.3 * chore: update search bar components to improve accessibility (v1.10.4) (#584) * update search bar components to improve accessibility * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * update tests * Update snapshots * Update snapshots * Update snapshots * add required aria attributes to pass WCAG * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * update storybook styling for dropdown items * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore: update generate license config (#586) * update generate license config * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * try using test branch of workflow * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * fix typo * Update snapshots * add generate_license_version param to yml * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * Update snapshots * Update snapshots * Update snapshots * update text in jsonlint-lines-primitives override * Update snapshots * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * remove extra dashed line * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * Update snapshots * point to v1 workflow branch after update in that repo * Update snapshots * Update snapshots * capitalization typo from prev PR * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.10.4 * feat: upgrade to React 19; add backwards compatibility test-site script (v1.11.0) (#589) * upgrade to React 19; add backwards compatibility test-site script * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * try updating run-tests.yml * codex: try fixing old react errors * update storybook command from p -> port * update types and fiddle with Mapbox pin code to pass storybook tests * wrap various tasts with act() to cut down on log warns * try to update storybook config to get tests to pass * Update snapshots * Update snapshots * Update snapshots * Update snapshots * rerun npm i in test site * slight code cleanup * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * nits * Update snapshots * Update snapshots * update kill command in visual coverage * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.11.0 * fix: handle mapbox padding race condition (v1.11.1) (#592) * add logic to only fit bounds when padding fits in canvas * release: v1.11.1 * fix: upgrade storybook version (#595) A vulnerability exists in storybook 8.5.0 that bundles the .env file in the static output during the storybook build. This vulnerability is fixed in version 8.6.15. J=VULN-40848 TEST=auto --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat: support autocomplete limits (v1.12.0) (#597) * support autocomplete limits * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.12.0 * hotfix: some symbol layers not showing up (v1.12.1) (#601) Layers that don't have name properties do not need to be localized (e.g. highway numbers). Localizing them was overriding their properties, which caused them to not show up on the map. J= WAT-5275 TEST=manual verified on test-site that road shields and route markers now show up, and place names are still localized as expected. * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * add parenthesis to make conditions clearer * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.12.1 * chore: reduce update snapshot commit hook flakiness (#600) * try awaiting to reduce update snapshot flakiness * additional update to static filters since that caused some snapshot failures too * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * ability to disable autocomplete in SearchBar (v1.12.2) (#605) J=WAT-5279 TEST=manual,auto tested on test-site added new test case to SearchBar.test.tsx and ran npm run test * release: v1.12.2 * ksearch: upgrade to Events API (#508) * ksearch: upgrade to Events API This PR upgrades our analytics calls to the next major version, also called the Events API. As part of this work, analytics calls have changed shape, and some deprecated properties have been dropped. J=WAT-4651 TEST=auto,manual Updated auto tests. Ran test site locally and saw events all the way to snowflake. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v2.0.0 * chore: add linting configuration and hook (#610) * add linter; update all files with correct linting * add husky config for pre-commit validation * rerun npm i in test site * Update snapshots * Update snapshots * Update snapshots * fix dropdown item widths; don't scroll through dropdown items on tab * Update snapshots * fix test for dropdown tab behavior change * update storybook test to not use tab to cycle through dropdown * Update snapshots * minor style nit --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v2.0.1 * fix: update map bounds check to use client values (#614) This was apparently causing more Invalid LngLat issues in iframes. Now, the map should be correctly sized and taking into account it's actual viewport size. The map's actual viewport is the canvas client size. canvas.width/height represents the device pixels, which is often larger than the CSS size. canvas.clientWidth/clientHeight uses the CSS pixel size, which is also what fitBounds uses, which is likely why we were running into issues before. J=WAT-5303 TEST=manual Packed tarball and saw a test VE site no longer run into the error * release: v2.0.2 --------- Co-authored-by: anguyen-yext2 <143001514+anguyen-yext2@users.noreply.github.com> Co-authored-by: anguyen-yext2 <anguyen@yext.com> Co-authored-by: Fondryext <160865254+Fondryext@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Maxfield Kouzel <mkouzel@yext.com> Co-authored-by: Chris Snyder <chris@chrissnyder.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Kyle Gerner <49618240+k-gerner@users.noreply.github.com> Co-authored-by: Kyle Gerner <kgerner@yext.com> Co-authored-by: Jacob Fondriest <jfondriest@yext.com>

@chrissnyder2337

* Support trusted publishing with OIDC (#558) * Bump search-headless-react version (to be published as v1.10.0) (#561) which includes change that supports facetAllowlist query parameter for vertical searches * release: v1.10.0-beta.0 * release: v1.10.0 * drop node 16 from github workflows (#567) * drop node 16 from github workflows We are dropping node 16 support, and have removed it from the related slapshot reusable workflows already. This PR drops it from the github workflows for this repo J=none TEST=none * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * v1.10.1 (#569) * v1.10.1 (#565) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: upgrade playwright version to avoid vuln This PR ups the playwright version used to avoid a vuln J=VULN-40423 TEST=compile * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * remove version upgrade workflow * remove version change * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * release: v1.10.1 * Move map to search location when there are no results (v1.10.2) (#570) J=WAT-5112 TEST=manual --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.10.2 * Fix orphaned ARIA references when collapsible=false (#579) Fix originally made in #576 by @chrissnyder2337 When collapsible={false}, FilterGroup now renders a plain div instead of CollapsibleSection, preventing orphaned aria-labelledby references that point to non-existent toggle button IDs. This fix improves WCAG 2.1 accessibility compliance (1.3.1 Info and Relationships; 4.1.2 Name, Role, Value) by ensuring screen readers only encounter properly labeled regions. --------- Co-authored-by: Claude <noreply@anthropic.com> * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: Chris Snyder <chris@chrissnyder.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.10.3 * release: v1.10.3-beta.0 * release: v1.10.3 * chore: update search bar components to improve accessibility (v1.10.4) (#584) * update search bar components to improve accessibility * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * update tests * Update snapshots * Update snapshots * Update snapshots * add required aria attributes to pass WCAG * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * update storybook styling for dropdown items * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore: update generate license config (#586) * update generate license config * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * try using test branch of workflow * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * fix typo * Update snapshots * add generate_license_version param to yml * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * Update snapshots * Update snapshots * Update snapshots * update text in jsonlint-lines-primitives override * Update snapshots * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * remove extra dashed line * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * Update snapshots * Update snapshots * point to v1 workflow branch after update in that repo * Update snapshots * Update snapshots * capitalization typo from prev PR * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.10.4 * feat: upgrade to React 19; add backwards compatibility test-site script (v1.11.0) (#589) * upgrade to React 19; add backwards compatibility test-site script * Automated update to THIRD-PARTY-NOTICES from github action's 3rd party notices check * try updating run-tests.yml * codex: try fixing old react errors * update storybook command from p -> port * update types and fiddle with Mapbox pin code to pass storybook tests * wrap various tasts with act() to cut down on log warns * try to update storybook config to get tests to pass * Update snapshots * Update snapshots * Update snapshots * Update snapshots * rerun npm i in test site * slight code cleanup * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * nits * Update snapshots * Update snapshots * update kill command in visual coverage * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.11.0 * fix: handle mapbox padding race condition (v1.11.1) (#592) * add logic to only fit bounds when padding fits in canvas * release: v1.11.1 * fix: upgrade storybook version (#595) A vulnerability exists in storybook 8.5.0 that bundles the .env file in the static output during the storybook build. This vulnerability is fixed in version 8.6.15. J=VULN-40848 TEST=auto --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat: support autocomplete limits (v1.12.0) (#597) * support autocomplete limits * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.12.0 * hotfix: some symbol layers not showing up (v1.12.1) (#601) Layers that don't have name properties do not need to be localized (e.g. highway numbers). Localizing them was overriding their properties, which caused them to not show up on the map. J= WAT-5275 TEST=manual verified on test-site that road shields and route markers now show up, and place names are still localized as expected. * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * Update snapshots * add parenthesis to make conditions clearer * Update snapshots * Update snapshots * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v1.12.1 * chore: reduce update snapshot commit hook flakiness (#600) * try awaiting to reduce update snapshot flakiness * additional update to static filters since that caused some snapshot failures too * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * ability to disable autocomplete in SearchBar (v1.12.2) (#605) J=WAT-5279 TEST=manual,auto tested on test-site added new test case to SearchBar.test.tsx and ran npm run test * release: v1.12.2 * ksearch: upgrade to Events API (#508) * ksearch: upgrade to Events API This PR upgrades our analytics calls to the next major version, also called the Events API. As part of this work, analytics calls have changed shape, and some deprecated properties have been dropped. J=WAT-4651 TEST=auto,manual Updated auto tests. Ran test site locally and saw events all the way to snowflake. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v2.0.0 * chore: add linting configuration and hook (#610) * add linter; update all files with correct linting * add husky config for pre-commit validation * rerun npm i in test site * Update snapshots * Update snapshots * Update snapshots * fix dropdown item widths; don't scroll through dropdown items on tab * Update snapshots * fix test for dropdown tab behavior change * update storybook test to not use tab to cycle through dropdown * Update snapshots * minor style nit --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v2.0.1 * fix: update map bounds check to use client values (#614) This was apparently causing more Invalid LngLat issues in iframes. Now, the map should be correctly sized and taking into account it's actual viewport size. The map's actual viewport is the canvas client size. canvas.width/height represents the device pixels, which is often larger than the CSS size. canvas.clientWidth/clientHeight uses the CSS pixel size, which is also what fitBounds uses, which is likely why we were running into issues before. J=WAT-5303 TEST=manual Packed tarball and saw a test VE site no longer run into the error * release: v2.0.2 * fix: unmount pin components asynchronously (#617) During a MapboxMap component update, the PinComponents are removed using a root.unmount() call and then rebuilt. The unmount, however, cannot happen while a render is in progress: previously, React would throw a warning and defer the actual unmount until the current render finished, but this change makes the deferral explicit. The MapboxMap render happens (during which the new PinComponents are built), and then the old PinComponents are destroyed. J=WAT-5325 TEST=manual Built and ran test-site. Confirmed that the "Attempted to synchronously unmount a root" error was no longer thrown. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Update snapshots * Update snapshots --------- Co-authored-by: anguyen-yext2 <143001514+anguyen-yext2@users.noreply.github.com> Co-authored-by: anguyen-yext2 <anguyen@yext.com> Co-authored-by: Fondryext <160865254+Fondryext@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Maxfield Kouzel <mkouzel@yext.com> Co-authored-by: Chris Snyder <chris@chrissnyder.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Kyle Gerner <49618240+k-gerner@users.noreply.github.com> Co-authored-by: Kyle Gerner <kgerner@yext.com> Co-authored-by: Jacob Fondriest <jfondriest@yext.com>

Fondryext commented Apr 7, 2025

View reviewed changes

Comment thread src/components/AnalyticsProvider.tsx

Comment thread src/hooks/useCardAnalytics.ts

Comment thread src/hooks/usePaginationAnalytics.ts

Comment thread src/hooks/usePaginationAnalytics.ts

Comment thread src/hooks/useSearchBarAnalytics.ts

k-gerner reviewed Apr 10, 2025

View reviewed changes

k-gerner reviewed Apr 14, 2025

View reviewed changes

Comment thread package.json Outdated

Comment thread src/components/sections/SectionHeader.tsx

Fondryext commented Jun 24, 2025

View reviewed changes

Comment thread src/hooks/useAnalytics.ts Outdated

Fondryext marked this pull request as ready for review June 24, 2025 13:45

Fondryext requested a review from a team as a code owner June 24, 2025 13:45

Fondryext commented Jul 3, 2025

View reviewed changes

vijay267 reviewed Aug 21, 2025

View reviewed changes

Fondryext and others added 9 commits September 22, 2025 14:27

Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…

6547763

…y notices check

Cleanup, renamings, and fixing error messages

e67ad64

Update checking, add wrapper

b02dfff

Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…

d9c470a

…y notices check

Fix at least some tests

87f9bcb

Add more wraparound services and values, to fully hide the

ab4883b

analytics import

Formatting changes, keeping the old event type for reporter

f046dc7

try and sort out rebasing

d1705b5

Fondryext force-pushed the dev/events-api branch from 39e70b3 to d1705b5 Compare September 22, 2025 19:49

github-actions Bot and others added 3 commits September 22, 2025 19:52

Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…

98e7df1

…y notices check

reformat

448478b

reduce types

c5d1aa0

Fondryext commented Sep 22, 2025

View reviewed changes

Comment thread tests/components/SearchBar.test.tsx

Fondryext and others added 5 commits September 23, 2025 11:12

adjust to allow some events to not need searchId

5de5651

remake package locks

fb09eda

Automated update to repo's documentation from github action

4f2bca6

Update snapshots

7995399

Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…

47bf38b

…y notices check

Fondryext and others added 10 commits January 8, 2026 16:46

try to remake package locks

f69b68a

Automated update to repo's documentation from github action

4aefefb

Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…

fecbaec

…y notices check

Update snapshots

2de2718

Update snapshots

5c97395

Update snapshots

9cbbd14

Update snapshots

6ee2d18

Update snapshots

4f4116b

Update snapshots

a6e07f4

Update snapshots

91c3801

vijay267 previously approved these changes Jan 9, 2026

View reviewed changes

Fondryext added 2 commits January 9, 2026 13:52

Merge branch 'main' into dev/events-api

ce1bee3

Add a variety of typescript fixes

e8cb854

Fondryext dismissed vijay267’s stale review via e8cb854 January 9, 2026 20:36

github-actions Bot added 2 commits January 9, 2026 20:38

Update snapshots

12a92bf

Update snapshots

7d97fde

k-gerner previously approved these changes Jan 9, 2026

View reviewed changes

Fondryext added 2 commits January 9, 2026 15:52

Add searchTerm to default passed params

e329b45

Merge branch 'main' into dev/events-api

819d864

Fondryext dismissed k-gerner’s stale review via 819d864 January 9, 2026 20:53

k-gerner previously approved these changes Jan 12, 2026

View reviewed changes

Merge branch 'main' into dev/events-api

54489ca

Fondryext dismissed k-gerner’s stale review via 54489ca January 13, 2026 14:15

Automated update to repo's documentation from github action

0f64d41

k-gerner approved these changes Jan 13, 2026

View reviewed changes

vijay267 approved these changes Jan 13, 2026

View reviewed changes

Fondryext merged commit 1c04a5c into main Jan 13, 2026
17 of 19 checks passed

Uh oh!

Conversation

Fondryext commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fondryext Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

vijay267 Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

vijay267 Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vijay267 Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

vijay267 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vijay267 Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vijay267 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k-gerner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fondryext commented Apr 7, 2025 •

edited

Loading

github-actions Bot commented Apr 7, 2025 •

edited

Loading

coveralls commented Apr 7, 2025 •

edited

Loading

vijay267 left a comment •

edited

Loading