Fix for "open new tabs next to current"#128
Fix for "open new tabs next to current"#128Kamui-Solo wants to merge 1 commit intoyfdyh000:Fixedfrom
Conversation
For example check option "open new tabs next to current" to "all", then press ctrl+shift+a to open addon manager, it will be opened outside of tab stack. This fix is for option works properly in all cases.
yfdyh000
left a comment
yfdyh000
left a comment
There was a problem hiding this comment.
Can you explain or cancel the changes for shouldStack?
| switch (TU_getPref("extensions.tabutils.openTabNext", 1)) { | ||
| case 1: //All | ||
| case 2: return aRelatedToCurrent || aReferrerURI || (aURI != "about:blank" && aURI != "about:newtab"); //All but New Tab | ||
| case 2: return aRelatedToCurrent || aReferrerURI || !isBlankPageURL(aURI); //All but New Tab |
There was a problem hiding this comment.
Again (lost from Github's review process): Good catch! It utilizes the gInitialPages in isBlankPageURL function.
It seems new tab page or addon manager page and in my case "simple mail" page, which opened from toolbar, they dosn't have referrer at all. And when we use: |
|
@Kamui-Solo Why the new non-relevant tab (like from toolbar, rather than the current tab) should be auto stack? |
2 participants
For example check option "open new tabs next to current" to "all", then press ctrl+shift+a to open addon manager, it will be opened outside of tab stack. This fix is for option works properly in all cases.