Skip to content

Conversation

toge
Copy link

@toge toge commented Aug 9, 2025

CMAKE_SYSTEM_VERSION is defined on specific system (ex. Windows and macOS).
Please add a condition to check CMAKE_SYSTEM_VERSION defined.

@yhirose
Copy link
Owner

yhirose commented Aug 9, 2025

@toge thanks for the pull request!
@sum01 @jimmy-park could you please review it for me as usual?

@sum01
Copy link
Contributor

sum01 commented Aug 10, 2025

Isn't it only not defined, as per spec, if cross-compiling and you forget to set it?
In a normal build it should get set automatically.

@yhirose
Copy link
Owner

yhirose commented Aug 14, 2025

@toge could you reply to the comment from @sum01?

@toge
Copy link
Author

toge commented Aug 15, 2025

@yhirose @sum01
I apologize for my misunderstanding.

This occurred while creating the vcpkg port, but since it is a limitation on the vcpkg side, I will address it with a vcpkg patch.

I am sorry for taking up your valuable time.

@yhirose yhirose closed this Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants