Fix error reporting in SSLClient #2239
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `SSLClient` is used to connect to a plain-HTTP server (which can happen in clients due to some end-user misconfiguration) it can return a failure from the `send()` call without setting the `Error` reference to the corresponding error code. This can cause problems to callers, that may expect that, when the check like this is passed on the response: ```c++ if (res.error() == Error::Success) ``` then they can access the response contents with `res.value()`. When `SSLClient`'s connection fails - the contents `unique_ptr` is not set and an attemt to access it causes UB. This change fixes the `SSLClient::create_and_connect_socket` method making sure that, the `Error` value is set correctly when the `is_valid()` check fails.
|
@staticlibs could you please add a unit test in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
SSLClientis used to connect to a plain-HTTP server (which can happen in clients due to some end-user misconfiguration) it can return a failure from thesend()call without setting theErrorreference to the corresponding error code. This can cause problems to callers, that may expect that, when the check like this is passed on the response:if (res.error() == Error::Success)then they can access the response contents with
res.value(). WhenSSLClient's connection fails - the contentsunique_ptris not set and an attemt to access it causes UB.This change fixes the
SSLClient::create_and_connect_socketmethod making sure that, theErrorvalue is set correctly when theis_valid()check fails.