Extract TableNameAndAliasResolver to internal class + Add ActiveQuery::resetVia()
#494
+59
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vjik
commented
Oct 31, 2025
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 652 653 +1
===========================================
Files 42 43 +1
Lines 1610 1614 +4
===========================================
+ Hits 1610 1614 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samdark
reviewed
Oct 31, 2025
| /** | ||
| * @internal | ||
| */ | ||
| final class TableNameAndAliasResolver |
There was a problem hiding this comment.
Only in this place or somewhere else as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.