Add ability to pass FROM clause to UPDATE command
#1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1038 +/- ##
=========================================
Coverage 98.41% 98.41%
- Complexity 1644 1647 +3
=========================================
Files 117 117
Lines 4344 4353 +9
=========================================
+ Hits 4275 4284 +9
Misses 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tigrov
requested changes
Aug 19, 2025
Tigrov
approved these changes
Aug 20, 2025
|
And needs to fix |
|
Also needs to add tests with execution. Not all DBMS support Copy tests from |
vjik
reviewed
Aug 23, 2025
| return [$uniqueNames, $insertNames, null]; | ||
| } | ||
|
|
||
| protected function prepareFromTables(array|ExpressionInterface|string $from): array |
There was a problem hiding this comment.
This method identical to Query::from(). Can we remove duplicates?
There was a problem hiding this comment.
Yes, we can but we need to refactor a bit.
# Conflicts: # src/Command/AbstractCommand.php
vjik
reviewed
Sep 6, 2025
vjik
approved these changes
Sep 9, 2025
Co-authored-by: Sergei Predvoditelev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
yiisoft/dbchanges db-migration#299yiisoft/dbchanges active-record#447