Skip to content

Commit

Permalink
fix data loading state (calcom#18002)
Browse files Browse the repository at this point in the history
  • Loading branch information
sean-brydon authored Dec 4, 2024
1 parent a75a5b7 commit 3211c5b
Showing 1 changed file with 16 additions and 9 deletions.
25 changes: 16 additions & 9 deletions packages/features/insights/server/routing-events.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,13 @@ class RoutingEventsInsights {
}),
};

if (teamIds.length === 0 && !routingFormId) {
if (!organizationId) {
throw new Error("Organization ID is required");
}
formsWhereCondition.teamId = organizationId;
}

return formsWhereCondition;
}

Expand Down Expand Up @@ -344,7 +351,7 @@ class RoutingEventsInsights {
}[]
>`
WITH form_fields AS (
SELECT
SELECT
f.id as form_id,
f.name as form_name,
field->>'id' as field_id,
Expand All @@ -358,10 +365,10 @@ class RoutingEventsInsights {
${whereClause}
),
response_stats AS (
SELECT
SELECT
r."formId",
key as field_id,
CASE
CASE
WHEN jsonb_typeof(value->'value') = 'array' THEN
v.value_item
ELSE
Expand All @@ -371,16 +378,16 @@ class RoutingEventsInsights {
FROM "App_RoutingForms_FormResponse" r
CROSS JOIN jsonb_each(r.response::jsonb) as fields(key, value)
LEFT JOIN LATERAL jsonb_array_elements_text(
CASE
WHEN jsonb_typeof(value->'value') = 'array'
CASE
WHEN jsonb_typeof(value->'value') = 'array'
THEN value->'value'
ELSE NULL
END
) as v(value_item) ON true
WHERE r."routedToBookingUid" IS NULL
GROUP BY r."formId", key, selected_option
)
SELECT
SELECT
ff.form_id as "formId",
ff.form_name as "formName",
ff.field_id as "fieldId",
Expand All @@ -389,9 +396,9 @@ class RoutingEventsInsights {
ff.option_label as "optionLabel",
COALESCE(rs.response_count, 0)::integer as count
FROM form_fields ff
LEFT JOIN response_stats rs ON
rs."formId" = ff.form_id AND
rs.field_id = ff.field_id AND
LEFT JOIN response_stats rs ON
rs."formId" = ff.form_id AND
rs.field_id = ff.field_id AND
rs.selected_option = ff.option_id
WHERE ff.option_id IS NOT NULL
ORDER BY count DESC`;
Expand Down

0 comments on commit 3211c5b

Please sign in to comment.