Skip to content

Commit

Permalink
Pack: Fix vsce errors
Browse files Browse the repository at this point in the history
@types/vscode must be downgraded a bit to be compatible.

The latest vsce 3.1.0 version does not work with workspaces which are
symlinks, which is the case for our "lib" folder. I created a fork
and PR to fix this issue, but in the meantime, we need to use the
commit hash of the fix.
  • Loading branch information
deribaucourt committed Sep 26, 2024
1 parent 62c923c commit 00d01d6
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 11 deletions.
2 changes: 1 addition & 1 deletion client/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
},
"devDependencies": {
"@types/find": "^0.2.4",
"@types/vscode": "^1.93.0"
"@types/vscode": "^1.92.0"
},
"workspaces": [
"src/lib"
Expand Down
11 changes: 6 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -903,9 +903,9 @@
"@types/jest": "^29.5.13",
"@types/mocha": "^10.0.8",
"@types/node": "^22.5.5",
"@types/vscode": "^1.93.0",
"@types/vscode": "^1.92.0",
"@vscode/test-electron": "^2.4.1",
"@vscode/vsce": "^3.1.0",
"@vscode/vsce": "github:deribaucourt/vscode-vsce#b38dca06f918e70d4f93be4c5e713dbff3d05327",
"eslint": "^9.10.0",
"globals": "^15.9.0",
"jest": "^29.7.0",
Expand Down
2 changes: 1 addition & 1 deletion server/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"prepack": "cd .. && npm run compile"
},
"devDependencies": {
"@types/vscode": "^1.93.0"
"@types/vscode": "^1.92.0"
},
"workspaces": [
"../client/src/lib"
Expand Down

0 comments on commit 00d01d6

Please sign in to comment.