Skip to content

Fixed named argument aliases for Job launchers #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

Elkawaie
Copy link
Contributor

I found this error, here's a quick fix.

Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.73%. Comparing base (a8246cc) to head (24433c7).
Report is 1 commits behind head on 0.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                0.x     #174   +/-   ##
=========================================
  Coverage     99.73%   99.73%           
  Complexity      926      926           
=========================================
  Files           154      154           
  Lines          2976     2976           
=========================================
  Hits           2968     2968           
  Misses            8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yann-eugone
Copy link
Contributor

@Elkawaie what error did you found?

@Elkawaie
Copy link
Contributor Author

Elkawaie commented Jul 16, 2025

@Elkawaie what error did you found?

@yann-eugone When i use this configuration

yokai_batch:
    launcher:
        default: messenger
        launchers:
            messenger: messenger://messenger
            simple: simple://simple
            service: service://service?service=app.job.priority_messenger_job_launcher

And when i declare this:

    public function __construct(
        private JobLauncherInterface $serviceJobLauncher,
        private JobExecutionIdGeneratorInterface $idGenerator,
        private JobExecutionStorageInterface $storage,
        private AppSecurity $security,
    ) {
    }

$serviceJobLauncher has been injected with the service declared in default and not the one defined in the launchers

@yann-eugone
Copy link
Contributor

Thank you @Elkawaie

@yann-eugone yann-eugone changed the title Fix alias for Job Launcher argument Fixed named argument aliases for Job launchers Jul 17, 2025
@yann-eugone yann-eugone merged commit 536f28c into 0.x Jul 17, 2025
11 checks passed
@yann-eugone yann-eugone deleted the fix-alias-launcher-definition branch July 17, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants