Skip to content

Test enhancement#22

Open
peter279k wants to merge 1 commit intoyosymfony:masterfrom
peter279k:test_enhancement
Open

Test enhancement#22
peter279k wants to merge 1 commit intoyosymfony:masterfrom
peter279k:test_enhancement

Conversation

@peter279k
Copy link
Copy Markdown

Changed log

  • Add more tests.
  • Set the phpunit version in require-dev.
  • Use composer update because it can let the different PHP versions to install proper packages when executing Travis CI build.

@yosymfony yosymfony closed this May 31, 2018
@peter279k
Copy link
Copy Markdown
Author

Can you explain why closing PR?

@yosymfony yosymfony reopened this Jun 9, 2018
@yosymfony
Copy link
Copy Markdown
Owner

It was a mistake

@peter279k
Copy link
Copy Markdown
Author

@yosymfony, thank you for your reply.
If possible, can you review them and suggest the recommendation?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants