Skip to content

Implicit nullables are deprecated in PHP 8.4 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arokettu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implicit nullables are deprecated in PHP 8.4 #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Exception/ParseException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class ParseException extends \RuntimeException
* @param string|null $parsedFile The file name where the error occurred
* @param Exception $previous The previous exception
*/
public function __construct(string $message, int $parsedLine = -1, string $snippet = null, string $parsedFile = null, \Exception $previous = null)
public function __construct(string $message, int $parsedLine = -1, ?string $snippet = null, ?string $parsedFile = null, ?\Exception $previous = null)
{
$this->parsedFile = $parsedFile;
$this->parsedLine = $parsedLine;
Expand Down
2 changes: 1 addition & 1 deletion src/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ private function unexpectedTokenError(Token $token, string $expectedMsg) : void
throw new SyntaxErrorException($msg);
}

private function syntaxError($msg, Token $token = null) : void
private function syntaxError($msg, ?Token $token = null) : void
{
if ($token !== null) {
$name = $token->getName();
Expand Down