Skip to content

release: 4.0.1#1418

Merged
jpic merged 1 commit into
yourlabs:masterfrom
PurpleToti:release/4.0.1
May 27, 2026
Merged

release: 4.0.1#1418
jpic merged 1 commit into
yourlabs:masterfrom
PurpleToti:release/4.0.1

Conversation

@PurpleToti
Copy link
Copy Markdown

@PurpleToti PurpleToti commented May 27, 2026

Summary

Context

#1417 reports a regression in 4.0.0 where ModelSelect2(Multiple) without an AJAX URL only renders already-selected choices on edit forms. The root cause was Select2InitialRenderMixin.render() (added in 9eabac0) unconditionally filtering choices.queryset to pk__in=selected_pks at render time, regardless of whether a URL was configured. This was already fixed in master by 12efd27 (removed the mixin entirely). The fix just needs to ship as a patch release.

The 4.0.1 CHANGELOG stub already existed (for #1333); this PR adds the #1417 entry and bumps the version so a PyPI release can be cut.

Test plan

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a regression in ModelSelect2(Multiple) widgets that was introduced in the previous release. Widgets without a configured URL now correctly display the complete queryset when initially rendering on the page, instead of limiting available choices to only those specific items that were previously selected by the user in their prior interactions.

Review Change Stack

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6894761d-9e5b-462a-9614-79b5311cec64

📥 Commits

Reviewing files that changed from the base of the PR and between f6b2f29 and b7f1262.

📒 Files selected for processing (2)
  • CHANGELOG
  • pyproject.toml

📝 Walkthrough

Walkthrough

This patch release updates the package version to 4.0.1 and documents a fix for issue #1417, where ModelSelect2(Multiple) widgets without AJAX URLs now correctly render the full queryset instead of only showing already-selected choices.

Changes

Release 4.0.1

Layer / File(s) Summary
Version bump and changelog entry
pyproject.toml, CHANGELOG
Version incremented from 4.0.0 to 4.0.1. Changelog documents fix for #1417: ModelSelect2(Multiple) without AJAX URL now renders full queryset on initial non-AJAX rendering.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A tiny hop to fix a hop,
When widgets showed just chosen tops,
Now queryset flows like water free,
In 4.0.1, all choices we see! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'release: 4.0.1' clearly and concisely indicates a version release, which directly matches the PR's primary objective of releasing version 4.0.1.
Linked Issues check ✅ Passed The PR updates version to 4.0.1 and documents a fix for issue #1417 in the CHANGELOG, addressing the regression where non-AJAX ModelSelect2 widgets showed only selected items instead of the full queryset.
Out of Scope Changes check ✅ Passed All changes are scoped to the release: version bump in pyproject.toml and CHANGELOG update for issue #1417. No unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jpic jpic merged commit 008dd48 into yourlabs:master May 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: ModelSelect2Multiple without URL only renders already-selected choices in 4.0.0 (regression from 3.x)

3 participants