refactor: BoxButton / TextButton 속성명 수정 #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 스토리 이름이 같이 바뀌어버림 ...........
- 외형 -> 위계
- 할당 가능한 값 앞에 text 붙임
4 tasks
seocylucky
approved these changes
Dec 7, 2024
|
|
||
| ```tsx | ||
| <TextButton size="medium" hierarchy="primary" disabled={true}> | ||
| <TextButton size="medium" variant="primary" disabled={true}> |
Member
There was a problem hiding this comment.
여기에 나오는 variant="primary" => variant="textPrimary" 로 바꿔야할 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
기존 코드에 영향을 미치지 않는 변경사항
BoxButton과 TextButton의 속성
hierarchy를variant로 변경했습니다variant속성에 할당 가능한 값 종류가 바뀌었습니다 (이름만 바뀜)BoxButton
TextButton
2️⃣ 알아두시면 좋아요!
3️⃣ 추후 작업
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?