Skip to content

config: modify github workflow for Handy distribution #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nijuy merged 3 commits into from
Jan 3, 2025
Merged

config: modify github workflow for Handy distribution #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba7aecd
chore: deploy.yml 수정
nijuy Jan 2, 2025
1e9e210
chore: 1.1.3 -> 2.0.0
nijuy Jan 2, 2025
a847b2c
fix: packageManager 버전 수정
nijuy Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout source code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up pnpm
uses: pnpm/action-setup@v2
uses: pnpm/action-setup@v4
with:
version: 8
version: 9

- name: Set up Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 20
cache: 'pnpm'

- name: Install dependencies
run: pnpm install
Expand All @@ -33,7 +34,7 @@ jobs:

- name: Extract version from package.json
id: version
run: echo ::set-output name=VERSION::$(node -p "require('./package.json').version")
run: echo "VERSION=$(node -p "require('./package.json').version")" >> $GITHUB_OUTPUT

- name: Deploy to s3
env:
Expand All @@ -44,7 +45,7 @@ jobs:
--recursive \
--region ap-northeast-2 \
./storybook-static \
s3://yds-react-storybook/${{ steps.version.outputs.VERSION }}
s3://handy-react-storybook/${{ steps.version.outputs.VERSION }}

- name: Publish to NPM
run: npm publish
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"name": "@yourssu/design-system-react",
Copy link
Collaborator Author

@nijuy nijuy Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

라이브러리명/버전 관리에 대해 의견 필요한 부분이 있어 추가 코멘트 달아두겠습니다

npm에 배포되는 라이브러리명은 그대로 @yourssu/design-system-react로 유지했습니다..!

인수인계의 간편함 등을 이유로 내부에서 디자인 시스템을 지칭하는 용어가 YDS에서 handy로 바뀌었는데
추구하는 원칙이 크게 바뀌면 용어는 바뀔 수도 있는 거고? 그럴 때마다 라이브러리명을 바꾸는 게 맞나??? 싶었어요

조직명과 react용 디자인 시스템이라는 의미만 담긴 현 이름을 유지하는 게 적절하다고 생각해서 이렇게 했습니다
메이저 버전만 2로 올렸어요

혹시 다른 의견 있으면 코멘트 주세용

Copy link
Collaborator Author

@nijuy nijuy Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seocylucky 어푸룹은 효민구에게 받았는데 여기 의견이 있나 궁금해서 슬랙 드렸던 거였어요!!
이모지 확인했읍니다 빠른 확인 고마웡요 👍

"packageManager": "[email protected]",
"private": false,
"version": "1.1.3",
"version": "2.0.0",
"description": "Yourssu Design System for React",
"keywords": [
"yourssu",
Expand Down Expand Up @@ -74,6 +75,5 @@
"vite-tsconfig-paths": "^4.2.0",
"webfontloader": "^1.6.28",
"xmldom": "^0.6.0"
},
"packageManager": "[email protected]"
}
}