Skip to content

fix: 페이지네이션 컴포넌트의 totalPages에 1도 허용해요 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fecapark merged 2 commits into from
Apr 16, 2025
Merged

fix: 페이지네이션 컴포넌트의 totalPages에 1도 허용해요 #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c473a4
bug: pagination > totalpages 1도 가능하게 변경
fecapark Apr 16, 2025
cfc43f2
docs: pagination > totalPage 사용법 문서 수정
fecapark Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Pagination/Pagination.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const onPageChange = (page: number) => { ... };

### totalPage

전체 페이지 수를 의미하는 프로퍼티입니다. 2 미만의 값을 넣을 경우 에러가 발생합니다.<br />
전체 페이지 수를 의미하는 프로퍼티입니다. 1 미만의 값을 넣을 경우 에러가 발생합니다.<br />
`totalPage <= 5`일 때, 이전/다음 버튼은 생성되지 않습니다.

<Canvas of={PaginationStories.TotalPage} />
Expand Down
2 changes: 1 addition & 1 deletion src/components/Pagination/Pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { StyledButton, StyledNav } from './Pagination.style';
import { PaginationProps } from './Pagination.type';

export const Pagination = ({ totalPage, initialPage = 1, onPageChange }: PaginationProps) => {
if (totalPage <= 1) throw new Error('totalPage는 2 이상의 숫자여야 합니다.');
if (totalPage <= 0) throw new Error('totalPage는 1 이상의 숫자여야 합니다.');
if (initialPage > totalPage) throw new Error('initialPage는 totalPage보다 클 수 없습니다.');

const [currentPage, setCurrentPage] = useState(initialPage);
Expand Down