-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(doc): 新增codesandbox支持 #12332
Open
LadyChatterleyLover
wants to merge
10
commits into
youzan:main
Choose a base branch
from
LadyChatterleyLover:lp-feat-codeSandBox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(doc): 新增codesandbox支持 #12332
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
83af214
feat(doc): 新增codesandbox支持
LadyChatterleyLover 82f7309
feat(doc): 新增codesandbox支持
LadyChatterleyLover ca30953
Merge branch 'main' into lp-feat-codeSandBox
LadyChatterleyLover a1d27f2
chore(doc): 更新依赖
LadyChatterleyLover e63f219
refactor(Doc): 替换codesandbox依赖
LadyChatterleyLover 893dd46
Merge branch 'main' into lp-feat-codeSandBox
LadyChatterleyLover 002cef5
refactor(Doc): 删除注释代码
LadyChatterleyLover ee349f5
fix: 解决冲突
LadyChatterleyLover 4902779
chore: 更新依赖
LadyChatterleyLover ceee8e1
refactor(Doc): 将依赖和配置替换为vite
LadyChatterleyLover File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
packages/vant-cli/site/desktop/components/getCodeSandboxParams.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
import { getParameters } from 'codesandbox/lib/api/define'; | ||
|
||
const indexHtml = `<!DOCTYPE html> | ||
<html lang="en"> | ||
<head> | ||
<title>Vant Demo</title> | ||
</head> | ||
<body> | ||
<div id="app"></div> | ||
</body> | ||
</html> | ||
`; | ||
|
||
const App = ` | ||
<template> | ||
<demo /> | ||
</template> | ||
|
||
<script> | ||
import { defineComponent } from "vue"; | ||
import Demo from "./Demo.vue"; | ||
|
||
export default defineComponent({ | ||
components: { | ||
Demo, | ||
}, | ||
}); | ||
</script>`; | ||
|
||
const mainJs = ` | ||
import { createApp } from 'vue'; | ||
import Vant from 'vant'; | ||
import App from './App.vue'; | ||
import 'vant/lib/index.css'; | ||
|
||
const app = createApp(App) | ||
app.use(Vant); | ||
app.mount("#app"); | ||
`; | ||
|
||
export function getCodeSandboxParams(code, meta) { | ||
return getParameters({ | ||
files: { | ||
'package.json': { | ||
content: JSON.stringify( | ||
{ | ||
title: meta.title, | ||
dependencies: { | ||
vue: 'latest', | ||
vant: 'latest', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Vant CLI 是一个通用的组件库工具,所以代码里不能和 vant 包产生耦合,这种可以通过参数控制 |
||
}, | ||
devDependencies: { | ||
'@vue/cli-plugin-babel': '~4.5.0', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 可以换成 Vite 吗 |
||
}, | ||
}, | ||
null, | ||
2, | ||
), | ||
isBinary: false, | ||
}, | ||
'index.html': { | ||
content: indexHtml, | ||
isBinary: false, | ||
}, | ||
'src/Demo.vue': { | ||
content: code, | ||
isBinary: false, | ||
}, | ||
'src/App.vue': { | ||
content: App, | ||
isBinary: false, | ||
}, | ||
'src/main.js': { | ||
content: mainJs, | ||
isBinary: false, | ||
}, | ||
}, | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个依赖让 lock 文件增加了 1600 行,而 Vant 仓库是希望严格控制依赖梳理的。
能否看一下是否有体积更小的依赖。。