Skip to content

fix: add tailwindcss dependency #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

hyoban
Copy link
Contributor

@hyoban hyoban commented Apr 14, 2025

I added the tailwindcss dependency and upgraded other dependencies to the latest

@yusukebe
Copy link
Owner

Hey @hyoban

Thank you for the PR. I'm not sure we should add tailwindcss to the deps. tailwindcss is already in the dependencies of hono-vite-react-stack. What package manager do you use?

@yusukebe
Copy link
Owner

This yusukebe/hono-vite-react-stack#5 is a related issue.

I hope that we should not force the user to add tailwindcss by themselves; it's better that the hono-vite-react-stack includes it. What do you think of this issue?

@hyoban
Copy link
Contributor Author

hyoban commented Apr 14, 2025

By default, pnpm does not hoist dependencies, so this problem will occur.

[vite] Internal server error: Can't resolve 'tailwindcss' in
  Plugin: @tailwindcss/vite:generate:serve

In addition, I think tailwindcss should be treated the way react is treated, so that the dependency of hono-vite-react-stack only includes vite-related plugins.

Doing so gives users version control authority, whether they want to stay on an older version or upgrade to a newer version more easily.

So I also created yusukebe/hono-vite-react-stack#18 to move it.

Copy link
Owner

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Owner

@hyoban

Thanks for the explanation. I understood well. Merging this PR.

@yusukebe yusukebe merged commit 2ee9ec1 into yusukebe:main Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants