Skip to content

Implement next/Image to company logo on career page #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yuta519
Copy link
Owner

@yuta519 yuta519 commented Dec 7, 2022

Change Summary

  • Replace tags to on Modal component
  • Create next.config.js for external file URL

Why changed

  • By using , the system needs to fetch the company logos for every rendering.
  • It's too slow.

@yuta519 yuta519 marked this pull request as ready for review December 7, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant